Closed
Bug 1873965
Opened 1 year ago
Closed 1 year ago
Submitting inline comments using Conduit API
Categories
(Conduit :: Phabricator, task)
Conduit
Phabricator
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: suhaib, Assigned: suhaib)
Details
Currently, we can use the Conduit API to create inline comment drafts (i.e., using the differential.createinline
endpoint); however, they stay as "unsubmitted". Before https://secure.phabricator.com/D21225 we could submit the inline comments using the differential.createcomment
endpoint by setting the attach_inlines
constraint to be true
.
It appears that submitting inline comment drafts through the API is currently not possible.
Possible solutions:
- Revert https://secure.phabricator.com/D21225
- Implement the support in the
differential.edit
endpoint for submitting inline comments directly, without creating drafts (mentioned in D21225/comment)
Assignee | ||
Updated•1 year ago
|
Assignee: nobody → smujahid
Comment 1•1 year ago
|
||
Merged
https://github.com/mozilla-conduit/phabricator/commit/1cf16d827c84a16974eeb1060236754de2c07702
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•