1874007 - Fix WPT /storage-access-api/ when blocking 3pc be default in TCP

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task)

Description

[Benjamin VanderSloot [:bvandersloot]]

There are a mix of failures here. Some may be tests that need fixing and others may indicate incorrect behavior of our blocking's interaction with the Storage Access API. We expect active unpartitioned storage access to allow 3pc use.

Comment 1

[Leander Schwarz]

Attachment: Bug 1874007 - Fix WPT /storage-access-api/* when blocking 3pc by disabling optInPartitioning for failing tests, enabling for an unexpected pass (see description). r?bvandersloot

requestStorageAccess-ABA.tentative.sub.https.window.js (html) - Uses CanAccessCookiesViaHTTP() and CanAccessCookiesViaJS() to check cookie access from third-party iframe, set cookies do not have "Partitioned".

requestStorageAccess-cross-origin-iframe-navigation.sub.https.window.js (html) - Uses HasUnpartitionedCookie(), SetFirstPartyCookieAndUnsetStorageAccessPermission() to check cookie access from third-part ifram, cookies do not have "Partitioned".

requestStorageAccess-cross-site-iframe.sub.https.window.js (html) - Uses CanAccessCookiesViaHTTP() and CanAccessCookiesViaJS() to check cookie access from third-party iframe, set cookies do not have "Partitioned".

requestStorageAccess-cross-site-sibling-iframes.sub.https.window.js (html) - Uses HasUnpartitionedCookie(), SetFirstPartyCookie...() as well as setting and reading cookies dircetly to check cookie access from third-party iframe, cookies do not have "Partitioned".

requestStorageAccess-dedicated-worker.tentative.sub.https.window.js (html) - Uses HasUnpartitionedCookie(), SetFirstPartyCookieAndUnsetStorageAccessPermission() to check cookie access from third-part ifram, cookies do not have "Partitioned".

requestStorageAccess-nested-cross-site-iframe.sub.https.window.js (html) - Uses CanAccessCookiesViaHTTP() and CanAccessCookiesViaJS() to check cookie access from third-party iframe, set cookies do not have "Partitioned".

requestStorageAccess-web-socket.tentative.sub.https.window.js (html) - Uses HasUnpartitionedCookie(), SetFirstPartyCookieAndUnsetStorageAccessPermission() to check cookie access from third-part ifram, cookies do not have "Partitioned".

storageAccess.testdriver.sub.html - Uses CanFrameWriteCookie() to check cookie access from third-party, passes with optInPartitioning enabled, since cookies are set without "Partitioned", before cookies were set because of dFPI which lead to the test failing.

All mentioned functions found in https://searchfox.org/mozilla-central/source/testing/web-platform/tests/storage-access-api/helpers.js#133 after this line.

Comment 2

[Leander Schwarz]

Attachment: Bug 1874007 - Remove exception for passing WPT storage-access-api/storageAccess.testdriver.sub.html test when blocking 3pc by default. r?bvandersloot

Comment 3

[Leander Schwarz]

The initial failures from below run no longer reproduce, the patch removes an exception for a test that now passes:
Failing run:
https://treeherder.mozilla.org/jobs?repo=try&revision=926890d0114834b777f592b60fad8fc0645d8b20

Recent run:
https://treeherder.mozilla.org/jobs?repo=try&revision=74c771ffbf16ca1e45d48e6302cde39616f1c8ee

Recent run of recently failing tests + removed exception patch:
https://treeherder.mozilla.org/jobs?repo=try&revision=5ed1b7afef15b894a95345638cc6932df4cb14d6

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/497a7a2f3633
Remove exception for passing WPT storage-access-api/storageAccess.testdriver.sub.html test. r=bvandersloot

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing wpt failures on storageAccess.testdriver.sub.html

Backout link

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/303d3d1886d2
Remove exception for passing WPT storage-access-api/storageAccess.testdriver.sub.html test when blocking 3pc by default. r=bvandersloot

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/303d3d1886d2