1874014 - Issues with Copy functionality after removing Screenshots button from Toolbar

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect)

Description

[Simona Badau, Desktop QA]

Attachment: Screen Recording with Copy after Restore to Default.mov

Found in

• Nightly 123.0a1

Affected versions

• Nightly 123.0a1

Tested platforms

• Affected platforms: macOS 13

Preconditions

• 'screenshots.browser.component.enabled' is set to true in about:config
• Place the Screenshots button in the Address Toolbar via Customize Toolbar.

Steps to reproduce

1. Go to Customize Toolbar and click on Restore Defaults.
2. Navigate to any website and enable Screenshots.
3. Do a click selection and then click on "Copy".
4. Enable Screenshots again -> click on Save visible -> click on Copy.

Expected result

• "Screenshots copied!" notification should be displayed each time a screenshot is copied.
• The Save visible dialog should be dismisses upon clicking the Copy button.

Actual result

• The "Screenshot copied!" notification is not displayed, and the Save visible dialog is not dismissed upon clicking the Copy button.

Regression range

• This is not a regression, it's reproducible only when enabling the component version of Screenshots.

Additional notes

• The Save visible dialog is properly dismissed if the pref 'screenshots.browser.component.enabled' is set to false in about:config.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sbadau, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1874014 - Check that screenshots anchor is connected to document. r=sfoster

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e8dac0c2b78
Check that screenshots anchor is connected to document. r=sfoster

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0e8dac0c2b78

Comment 5

[Simona Badau, Desktop QA]

Verified as fixed on the latest Nightly 123.0a1 - tested on macOS 13, Ubuntu 22.04 x64 and Windows 10 x64.