1874045 - [wpt-sync] Sync PR 43933 - Fix HTML directionality inheritance for empty <bdi> elements with no dir attribute.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43933 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43933
Details from upstream follow.

L. David Baron <[e-mail]> wrote:

Fix HTML directionality inheritance for empty <bdi> elements with no dir attribute.

This correctly initializes the flag indicating that the HTML
directionality is inherited from the parent for \<bdi> elements, which
behaves like it has dir=auto by default. Even without this change, it
gets initialized correctly when a dir attribute is changed or when the
text content of the element changes.

This also clears the same flag when the dir attribute changes. This
should affect some other cases of dir attribute changes, but we somehow
didn't hit it until fixing the previous bug exposed the problem.

This fixes the failure of a test that I added in
https://github.com/web-platform-tests/wpt/pull/43896 in response to
noticing and fixing an error I made in the HTML spec in
https://github.com/whatwg/html/pull/10005 .

Bug: 576815
Change-Id: I3006d45079694d90dd178f8c439e22f6419bd992
Reviewed-on: https://chromium-review.googlesource.com/5186678
WPT-Export-Revision: 39bf5b2f7380c2de91f720a6954ec1e3423c92b6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e2b9eb9ff3509152d1f97a696622b5cf2b34637

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/text-level-semantics/the-bdi-element/bdi-auto-dir-default.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47d17edd3a1e
[wpt PR 43933] - Fix HTML directionality inheritance for empty <bdi> elements with no dir attribute., a=testonly
https://hg.mozilla.org/integration/autoland/rev/a382e20c59ba
[wpt PR 43933] - Update wpt metadata, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/47d17edd3a1e
https://hg.mozilla.org/mozilla-central/rev/a382e20c59ba