Closed Bug 1874063 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 43935 - [Protected Audiences] Add some surrogate pair generateBid() WPT tests.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox123 fixed)

Status:
RESOLVED FIXED
Milestone:
123 Branch
Tracking Flags:
Tracking Status
firefox123 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 43935 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43935
Details from upstream follow.

Matt Menke <mmenke@chromium.org> wrote:

[Protected Audiences] Add some surrogate pair generateBid() WPT tests.

In particular, for fields that take strings that are already tested in
interest-group-passed-to-generate-bid.https.window.js, add surrogate
pair tests.

Also switch priorityVectors / prioritySignalsOverrides from using
DOMStrings to using USVStrings for now, despite the spec indicating we
should take DOMStrings. We may want to switch back at some point, when
we're better situated to handle USVStrings.

Bug: 1517378, 1425952
Change-Id: I214a71c71e2b419fed7426ad610152744ee40a8f

Reviewed-on: https://chromium-review.googlesource.com/5186379
WPT-Export-Revision: 73680b3a2fa36e903fca9dd7bca7f684221ca1ef

PR 43935 applied with additional changes from upstream: 7d3922460aafef9b34884816351c14c0ac420c83, 89d67fdba1a026ea9d3ab7612e3e490b826b07e4, 871c3cb7f61569ea2d70dcb96fb40c1b409ad0e1

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 5 subtests

Status Summary

Firefox

OK : 9
FAIL: 43

Chrome

OK : 9
FAIL: 43

Safari

OK : 9
FAIL: 43

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /fledge/tentative/interest-group-passed-to-generate-bid.https.window.html?26-30 [wpt.fyi]
    • InterestGroup.trustedBiddingSignalsURL with non-normalized value.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.trustedBiddingSignalsURL with unpaired surrogate characters, which should be replaced with "\uFFFD".: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.trustedBiddingSignalsKeys not set.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.trustedBiddingSignalsKeys.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.trustedBiddingSignalsKeys with non-normalized values.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fledge/tentative/interest-group-passed-to-generate-bid.https.window.html?1-5 [wpt.fyi]
    • InterestGroup.owner.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.owner with non-normalized origin.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.owner is URL.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.name.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.name with unicode characters.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fledge/tentative/interest-group-passed-to-generate-bid.https.window.html?21-25 [wpt.fyi]
    • InterestGroup.executionMode frozen-context.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.executionMode group-by-origin.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.executionMode has non-standard string.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.trustedBiddingSignalsURL not set.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.trustedBiddingSignalsURL.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fledge/tentative/interest-group-passed-to-generate-bid.https.window.html?6-10 [wpt.fyi]
    • InterestGroup.name with empty name.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.name with unpaired surrogate characters, which should be replaced with "\uFFFD".: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.lifetimeMs should not be passed in.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.priority should not be passed in, since it can be changed by auctions.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.priorityVector undefined.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fledge/tentative/interest-group-passed-to-generate-bid.https.window.html?36-40 [wpt.fyi]
    • InterestGroup.trustedBiddingSignalsSlotSizeMode unrecognized value.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.userBiddingSignals not set.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.userBiddingSignals is integer.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.userBiddingSignals is array.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.userBiddingSignals is object.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fledge/tentative/interest-group-passed-to-generate-bid.https.window.html?16-20 [wpt.fyi]
    • InterestGroup.enableBiddingSignalsPrioritization unrecognized.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.enableBiddingSignalsPrioritization false.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.enableBiddingSignalsPrioritization true.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.executionMode not present.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.executionMode compatibility.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fledge/tentative/interest-group-passed-to-generate-bid.https.window.html?41-last [wpt.fyi]
    • InterestGroup.userBiddingSignals unpaired surrogate characters, which should be kept as-is.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.userBiddingSignals unpaired surrogate characters in an object, which should be kept as-is.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.nonStandardField.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fledge/tentative/interest-group-passed-to-generate-bid.https.window.html?11-15 [wpt.fyi]
    • InterestGroup.priorityVector empty.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.priorityVector.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.priorityVector with unpaired surrogate character.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.prioritySignalsOverrides should not be passed in, since it can be changed by auctions.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.enableBiddingSignalsPrioritization not set.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /fledge/tentative/interest-group-passed-to-generate-bid.https.window.html?31-35 [wpt.fyi]
    • InterestGroup.trustedBiddingSignalsKeys unpaired surrogate characters, which should be replaced with "\uFFFD".: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.trustedBiddingSignalsSlotSizeMode empty.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.trustedBiddingSignalsSlotSizeMode none.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.trustedBiddingSignalsSlotSizeMode slot-size.: FAIL (Chrome: FAIL, Safari: FAIL)
    • InterestGroup.trustedBiddingSignalsSlotSizeMode all-slots-requested-sizes.: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d2e968ac0be [wpt PR 43935] - [Protected Audiences] Add some surrogate pair generateBid() WPT tests., a=testonly https://hg.mozilla.org/integration/autoland/rev/830bf216a0f1 [wpt PR 43935] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8d2e968ac0be
https://hg.mozilla.org/mozilla-central/rev/830bf216a0f1

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox123: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.