1874107 - wayland proxy does not close its sockets

Status: RESOLVED DUPLICATE of bug 1874857

(Core :: Widget: Gtk, defect, P3)

Description

[:gerard-majax]

Yesterday I was hitting a startup crash and it looks like wayland-proxy did not like that, there's a bunch of leftover sockets:

$ ll /run/user/1000/wayland-proxy-*
srwxrwxr-x 1 alex alex 0 janv. 10 18:58 /run/user/1000/wayland-proxy-407132
srwxrwxr-x 1 alex alex 0 janv. 10 18:58 /run/user/1000/wayland-proxy-408722
srwxrwxr-x 1 alex alex 0 janv. 10 18:59 /run/user/1000/wayland-proxy-409265
srwxrwxr-x 1 alex alex 0 janv. 10 18:59 /run/user/1000/wayland-proxy-410718
srwxrwxr-x 1 alex alex 0 janv. 10 19:01 /run/user/1000/wayland-proxy-411456
srwxrwxr-x 1 alex alex 0 janv. 10 19:15 /run/user/1000/wayland-proxy-430338
srwxrwxr-x 1 alex alex 0 janv. 10 19:15 /run/user/1000/wayland-proxy-430466
srwxrwxr-x 1 alex alex 0 janv. 10 19:16 /run/user/1000/wayland-proxy-430678
srwxrwxr-x 1 alex alex 0 janv. 10 19:16 /run/user/1000/wayland-proxy-430790
srwxrwxr-x 1 alex alex 0 janv. 10 19:17 /run/user/1000/wayland-proxy-431518
srwxrwxr-x 1 alex alex 0 janv. 10 19:17 /run/user/1000/wayland-proxy-431633
srwxrwxr-x 1 alex alex 0 janv. 10 19:17 /run/user/1000/wayland-proxy-431740
srwxrwxr-x 1 alex alex 0 janv. 10 19:17 /run/user/1000/wayland-proxy-431852
srwxrwxr-x 1 alex alex 0 janv. 10 19:21 /run/user/1000/wayland-proxy-437934
srwxrwxr-x 1 alex alex 0 janv. 10 19:22 /run/user/1000/wayland-proxy-439340
srwxrwxr-x 1 alex alex 0 janv. 10 19:22 /run/user/1000/wayland-proxy-439678
srwxrwxr-x 1 alex alex 0 janv. 10 19:24 /run/user/1000/wayland-proxy-441967
srwxrwxr-x 1 alex alex 0 janv. 10 19:24 /run/user/1000/wayland-proxy-442081
srwxrwxr-x 1 alex alex 0 janv. 10 19:25 /run/user/1000/wayland-proxy-442184
srwxrwxr-x 1 alex alex 0 janv. 10 19:25 /run/user/1000/wayland-proxy-442297
srwxrwxr-x 1 alex alex 0 janv. 10 19:25 /run/user/1000/wayland-proxy-442306
srwxrwxr-x 1 alex alex 0 janv. 10 19:25 /run/user/1000/wayland-proxy-442418
srwxrwxr-x 1 alex alex 0 janv. 10 19:25 /run/user/1000/wayland-proxy-442619
srwxrwxr-x 1 alex alex 0 janv. 10 19:25 /run/user/1000/wayland-proxy-442732
srwxrwxr-x 1 alex alex 0 janv. 10 19:26 /run/user/1000/wayland-proxy-443003
srwxrwxr-x 1 alex alex 0 janv. 10 19:26 /run/user/1000/wayland-proxy-443118
srwxrwxr-x 1 alex alex 0 janv. 10 19:27 /run/user/1000/wayland-proxy-443520
srwxrwxr-x 1 alex alex 0 janv. 10 19:27 /run/user/1000/wayland-proxy-443635
srwxrwxr-x 1 alex alex 0 janv. 10 19:27 /run/user/1000/wayland-proxy-443647
srwxrwxr-x 1 alex alex 0 janv. 10 19:28 /run/user/1000/wayland-proxy-445447
srwxrwxr-x 1 alex alex 0 janv. 10 19:48 /run/user/1000/wayland-proxy-547363
srwxrwxr-x 1 alex alex 0 janv. 10 19:48 /run/user/1000/wayland-proxy-547490
srwxrwxr-x 1 alex alex 0 janv. 10 19:49 /run/user/1000/wayland-proxy-548784
srwxrwxr-x 1 alex alex 0 janv. 10 19:49 /run/user/1000/wayland-proxy-549170
srwxrwxr-x 1 alex alex 0 janv. 10 19:49 /run/user/1000/wayland-proxy-549287
srwxrwxr-x 1 alex alex 0 janv. 10 19:50 /run/user/1000/wayland-proxy-552783
srwxrwxr-x 1 alex alex 0 janv. 10 19:56 /run/user/1000/wayland-proxy-560256
srwxrwxr-x 1 alex alex 0 janv. 10 20:00 /run/user/1000/wayland-proxy-563772
srwxrwxr-x 1 alex alex 0 janv. 10 20:01 /run/user/1000/wayland-proxy-565317
srwxrwxr-x 1 alex alex 0 janv. 10 20:02 /run/user/1000/wayland-proxy-567301
srwxrwxr-x 1 alex alex 0 janv. 10 20:06 /run/user/1000/wayland-proxy-573422
srwxrwxr-x 1 alex alex 0 janv. 10 20:10 /run/user/1000/wayland-proxy-575751
srwxrwxr-x 1 alex alex 0 janv. 10 20:11 /run/user/1000/wayland-proxy-576969
srwxrwxr-x 1 alex alex 0 janv. 10 20:13 /run/user/1000/wayland-proxy-578226
srwxrwxr-x 1 alex alex 0 janv. 10 20:14 /run/user/1000/wayland-proxy-578846
srwxrwxr-x 1 alex alex 0 janv. 10 20:15 /run/user/1000/wayland-proxy-579859
srwxrwxr-x 1 alex alex 0 janv. 10 20:16 /run/user/1000/wayland-proxy-580865
srwxrwxr-x 1 alex alex 0 janv. 10 20:16 /run/user/1000/wayland-proxy-580979
srwxrwxr-x 1 alex alex 0 janv. 10 20:20 /run/user/1000/wayland-proxy-584949
srwxrwxr-x 1 alex alex 0 janv. 10 20:31 /run/user/1000/wayland-proxy-597029
srwxrwxr-x 1 alex alex 0 janv. 10 20:31 /run/user/1000/wayland-proxy-597145
srwxrwxr-x 1 alex alex 0 janv. 10 20:34 /run/user/1000/wayland-proxy-599566
srwxrwxr-x 1 alex alex 0 janv. 10 20:34 /run/user/1000/wayland-proxy-599696
srwxrwxr-x 1 alex alex 0 janv. 10 20:39 /run/user/1000/wayland-proxy-606533
srwxrwxr-x 1 alex alex 0 janv. 10 20:39 /run/user/1000/wayland-proxy-606664
srwxrwxr-x 1 alex alex 0 janv. 10 21:08 /run/user/1000/wayland-proxy-641721
srwxrwxr-x 1 alex alex 0 janv. 10 21:10 /run/user/1000/wayland-proxy-644813
srwxrwxr-x 1 alex alex 0 janv. 10 21:46 /run/user/1000/wayland-proxy-673490
srwxrwxr-x 1 alex alex 0 janv. 10 21:48 /run/user/1000/wayland-proxy-677533
srwxrwxr-x 1 alex alex 0 janv. 10 21:49 /run/user/1000/wayland-proxy-680769

Comment 1

[:gerard-majax]

(the currently active socket is /run/user/1000/wayland-proxy-680769, everything else is unconnected)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1743144

:stransky, since you are the author of the regressor, bug 1743144, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1874107 [Wayland] Implement EnableCleanUp()/CleanUp() to WaylandProxy() to rapid remove proxy tmp files from signal handlers r?emilio

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1874107 [Wayland] Clear up Wayland proxy from nsProfileLock::FatalSignalHandler r?jld

Depends on D198325

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1743144

Comment 6

[Bob Hood [:bhood]]

Curious where we are with this one. Phabricator says D198325 is ready to land. Did it actually land? If so, can we move D198326 now as well?

Comment 7

[Martin Stránský [:stransky] (ni? me)]

(In reply to Bob Hood [:bhood] from comment #6)

Curious where we are with this one. Phabricator says D198325 is ready to land. Did it actually land? If so, can we move D198326 now as well?

We need review of D198326.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Will be covered by Bug 1874857.