1874124 - Specify at least one foreground service type for each foreground service

Status: RESOLVED FIXED

(Firefox for Android :: General, task, P1)

Description

[Mihai Adrian Carare [:mcarare]]

When targeting Android 14, at least one foreground service type must be specified for each foreground service within the app.

See also: https://developer.android.com/about/versions/14/changes/fgs-types-required

Comment 1

[Mihai Adrian Carare [:mcarare]]

The first issue is with the Download service which should be declared as a dataSync type with the corresponding FOREGROUND_SERVICE_DATA_SYNC permission( I think we should declare that in the AC module, instead of in each app manifest).

Note that somewhere in a future version of Android, this foreground service type will be deprecated. It is recommended to migrate using a user-initiated data transfer or =WorkManager. I don't think we should do this in the scope of the upgrade, because while investigating it I found it somewhat limiting and difficult to refactor the existing code.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1874124 - Add foregroundServiceType for DownloadService and FOREGROUND_SERVICE_DATA_SYNC permission. (#5117)

Comment 3

[Jonathan Almeida [:jonalmeida]]

Another foreground service would be the AbstractPrivateNotificationService which might fall under either shortService or specialUse type where the latter would need a Play Store reasoning to be submitted for it to be used.

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1874124 - Add foregroundServiceType for private notification service and FOREGROUND_SERVICE_SPECIAL_USE permission. (#5119)

Comment 5

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/e4ab71369049aef8918009e1848296bf7882504d
[main] Bug 1874124 - Add foregroundServiceType for DownloadService and FOREGROUND_SERVICE_DATA_SYNC permission.

Comment 6

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/81622bd40f70650be71ce700c89c0541cade3722
[main] Bug 1874124 - Add foregroundServiceType for private notification service and FOREGROUND_SERVICE_SPECIAL_USE permission.

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1874124 - Add foregroundServiceType for Crash Services and FOREGROUND_SERVICE_SPECIAL_USE permission. (#5138)

Comment 8

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/2be68a92e4d31cfca0210e687864944ac7766ad4
[main] Bug 1874124 - Add foregroundServiceType for Crash Services and FOREGROUND_SERVICE_SPECIAL_USE permission.

Comment 9

[Chris Peterson [:cpeterson]]

The Android team has not been keeping our P1 bug list up to date, so we're resetting all our P1 bugs to P2 to avoid signalling that we're actively working on bugs that we're not. The BMO documentation https://wiki.mozilla.org/BMO/UserGuide/BugFields#priority says P1 means "fix in the current release cycle" and P2 means "fix in the next release cycle or the following (nightly + 1 or nightly + 2)".

If you are actively working on this bug and expect to ship it in Fx 122 or 123, then please restore the priority back to P1.

Comment 10

[Mihai Adrian Carare [:mcarare]]

Closing this as no other services need changes.

Comment 11

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1874124 - Add foregroundServiceType for sample app CrashService and FOREGROUND_SERVICE_SPECIAL_USE permission (#5296)

Comment 12

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/7f20cfbeead6a5c050aa51e6ff8840a0f1fd120c
[main] Bug 1874124 - Add foregroundServiceType for sample app CrashService and FOREGROUND_SERVICE_SPECIAL_USE permission