Closed Bug 187428 Opened 22 years ago Closed 22 years ago

[FIX]link included in div-tag has active areas outside link

Categories

(Core :: Layout, defect, P1)

Product:
Core
Component:
Layout
Platform:
x86
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.3beta

People

(Reporter: gwen, Assigned: bzbarsky)

References

(
URL
)

Details

Attachments

(2 files)

Testcase for bug #187428
1.09 KB, text/html
Details
patch
686 bytes, patch
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021207 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021207 Phoenix/0.5

div align=center tag includes an image which is a link. The area next to the
image is active, the image itself is active, too. Crosshair-Cursor is displayed
correctly outside proper active area but not inside.

Looks fine in IE and Opera, but not in Mozilla and Phoenix

(Please excuse my bad English...)

Reproducible: Always

Steps to Reproduce:
1. Open Phoenix or Mozilla (Windows or FreeBSD)
2. Open http://oui-ja.de/entry.php?id=00706
3. Move cursor over image and next to image

Actual Results:  
Active area where no active-link-area is supposed to be.

Expected Results:  
Show only an active area above the image
*** Bug 187429 has been marked as a duplicate of this bug. ***
You have submitted a Phoenix-specific bug, but you are mentioning in the bug
report that you have tested it in Mozilla with the same results (and thus it's
NOT a Phoenix-specific bug!).
Component: General → Layout
Product: Phoenix → Browser
Version: unspecified → Trunk
reassign
Assignee: blaker → other
QA Contact: asa → ian
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20021212 Used for this
test
The cursor issue is caused by the following CSS in Mozilla's UA stylesheet:

*|*:-moz-any-link img, img[usemap], object[usemap] {
  border: 2px solid;
  cursor: pointer;
}

This sets the cursor to "pointer" on any image inside a link....  This could be 
rewritten as:

*|*:-moz-any-link img, img[usemap], object[usemap] {
  border: 2px solid;
}

img[usemap], object[usemap] {
  cursor: pointer;
}

Since we already set "cursor" on *|*:-moz-any-link in ua.css and that should 
inherit down to any images inside the link...

Of course given that rule all the rest of our behavior is correct; the only 
question is whether the rule should stay as-is.

As for the active region issue, the image is set to be a block and the entire 
block box (with width equal to the <body>) is thus inside the <a>.... and 
should all be active.
OS: Windows XP → All
Summary: link included div-tag has active areas outside link → link included in div-tag has active areas outside link
taking
Assignee: other → bzbarsky
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P1
Target Milestone: --- → mozilla1.3beta
Attached patch patch — — Splinter Review 

    
  

        Attachment #110678 -
        Flags: superreview?(dbaron)

        Attachment #110678 -
        Flags: review?(dbaron)

    
  
Summary: link included in div-tag  has active areas outside link → [FIX]link included in div-tag  has active areas outside link

    
    

    
  
Comment on attachment 110678 [details] [diff] [review]
patch

r+sr=dbaron if you move 'cursor: pointer' into the rule below rather than
creating a new rule

    
    

    
  
Good catch... checked in with just the move to the existing rule.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED

    
  

        Attachment #110678 -
        Flags: superreview?(dbaron)

        Attachment #110678 -
        Flags: review?(dbaron)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: