1874311 - Enable FxA toolbar button by default when user not signed in

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, task, P2)

Description

[Tarik Eshaq [:teshaq]]

We have 100% rollout to enable identity.fxaccounts.toolbar.defaultVisible, we should turn it on by default and let it ride the trains

Comment 1

[Tarik Eshaq [:teshaq]]

Attachment: Bug 1874311: Enables Account toolbar by default when signed out. r=skhamis

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2d10b063497
Enables Account toolbar by default when signed out. r=skhamis

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures at browser/base/content/test/sync/browser_sync.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/9fa106ff483eec6f67f8b702256d40a5f3336c07

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/sync/browser_sync.js | Button should be hidden with STATUS_NOT_CONFIGURED -

Comment 4

[Vtay]

Could we also Uplift it to ESR?

Comment 5

[Tarik Eshaq [:teshaq]]

:Vtay great question, we can request the uplift once it re-lands (sorry for that! Some tests needed to also change to reflect that change in visibility)

I'll take a look at the state of the world in ESR to see if the change will cause any conflict or if all the implementation bits are already there - I'm not sure about the process to uplift to ESR but I'll find out

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21fe9b4f7e93
Enables Account toolbar by default when signed out. r=skhamis

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/21fe9b4f7e93