1874338 - cc-type field gets deleted from profile when matched select option found

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, defect, P3)

Description

[Issam Mani [:issammani]]

Attachment: displaying default icons for known credit card types

Description

When a select field of type cc-type is detected and matching known credit card network names to the one of the option fails, the cc-type field is deleted from the profile passed to the autocomplete popup. This in turn causes the icon next to the credit cards to show the default icon instead of the correct icons.

Example of a broken form

This form will cause the cc-type to be deleted from the profile, since we can't match any option to a know network ( visa, mastercard, ... )

<form>
  <input autocomplete="cc-name" />
  <input autocomplete="cc-number" />
  <input autocomplete="cc-exp" />
  <select autocomplete="cc-type" >
    <option> foo </option> 
  </select>
</form>

Comment 1

[Chris Peterson [:cpeterson]]

I hit this case on the checkout form on https://keylargoprincess.com/.

Comment 2

[Issam Mani [:issammani]]

Attachment: Bug 1874338 - Skip deleting cc-type field from credit card profile data when matching select option. r=dimi!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec2f6ca29b9e
Skip deleting cc-type field from credit card profile data when matching select option. r=dimi

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ec2f6ca29b9e

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:issammani, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.