1874347 - [wpt-sync] Sync PR 43959 - [text-spacing-trim] Fix available width when line-start needs reshape

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43959 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43959
Details from upstream follow.

Koji Ishii <[e-mail]> wrote:

[text-spacing-trim] Fix available width when line-start needs reshape

This patch moves the logic in ShapingLineBreaker to reshape
line-start to before computing the candidate break.

Candidate break is computed from available width, which
reshaping line-start may change.

The text-spacing-trim property may cause a large difference
when line-start reshaping occurs, large enough to find this
bug.

Bug: 1463891
Change-Id: Ie0f7c7cecafeaad38315bd1b9745c3073f9a8dc5

Reviewed-on: https://chromium-review.googlesource.com/5186201
WPT-Export-Revision: 7459e2311f5d8320852f53c77cf8b2ac8522a438

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a5f6175dc984217b83030b2ab8779bf1fad136e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-text/text-spacing-trim/text-spacing-trim-start-002.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/743420ca578c
[wpt PR 43959] - [text-spacing-trim] Fix available width when line-start needs reshape, a=testonly
https://hg.mozilla.org/integration/autoland/rev/976166a958a2
[wpt PR 43959] - Update wpt metadata, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/743420ca578c
https://hg.mozilla.org/mozilla-central/rev/976166a958a2