1874496 - [Screenshots] Cancel button cannot be focused with keyboard

Status: NEW

(Firefox :: Screenshots, defect, P2)

Description

[Morgan Reschenberg [:morgan]]

STR

1. Enable screenshots.browser.component.enabled in about:config
2. Navigate to en.wikipedia.org
3. Right click, select "take screenshot" from context menu
4. Attempt to tab to "Cancel" button

Expected:
the "cancel" button is included in the focus order

Actual:
focus only moves between the "screenshot visible" and "screenshot entire page"

S3 instead of S2 because user can hit ESC to cancel

Comment 1

[Niklas Baumgardner [:niklas]]

We fixed this issue in bug 1820015 and it has been verified by QA.
Are you able to reproduce this on today's Nightly?

Comment 2

[Morgan Reschenberg [:morgan]]

On today's nightly, I can tab to the cancel button, but there's an invisible "stop" between the last option in the upper right "save full page / save section" menu and the button itself. Also, if I tab past the button I cannot shift-tab back to it.

Comment 3

[Sam Foster [:sfoster] (he/him)]

(In reply to Morgan Reschenberg [:morgan] from comment #2)

On today's nightly, I can tab to the cancel button, but there's an invisible "stop" between the last option in the upper right "save full page / save section" menu and the button itself.

The invisible "stop" between the last option from the panel menu and the cancel button in the overlay is the <browser> element. That seems to be consistent with all the other chrome toolbar buttons - e.g. if I focus the url bar, tab gets me to the bookmark button, then the first tab in the toolbar button group (the library button for me), then the <browser>, then the first focusable element in the content document.

Also, if I tab past the button I cannot shift-tab back to it.

Yeah I can see that. It looks like the next tab stop after the overay's cancel button is the Firefox View button? I'm not sure why we're not going to the content document there. Shift+tab to try and get back to the overlay cancel button does eventually work, but its not the sequence you'd expect.

So I'm suggesting the first issue with tab stopping on the <browser> before getting to the "cancel" button is expected. But the 2nd issue is not. Do you agree?

Comment 4

[Morgan Reschenberg [:morgan]]

(In reply to Sam Foster [:sfoster] (he/him) from comment #3)

(In reply to Morgan Reschenberg [:morgan] from comment #2)

On today's nightly, I can tab to the cancel button, but there's an invisible "stop" between the last option in the upper right "save full page / save section" menu and the button itself.

The invisible "stop" between the last option from the panel menu and the cancel button in the overlay is the <browser> element. That seems to be consistent with all the other chrome toolbar buttons - e.g. if I focus the url bar, tab gets me to the bookmark button, then the first tab in the toolbar button group (the library button for me), then the <browser>, then the first focusable element in the content document.

Also, if I tab past the button I cannot shift-tab back to it.

Yeah I can see that. It looks like the next tab stop after the overay's cancel button is the Firefox View button? I'm not sure why we're not going to the content document there. Shift+tab to try and get back to the overlay cancel button does eventually work, but its not the sequence you'd expect.

So I'm suggesting the first issue with tab stopping on the <browser> before getting to the "cancel" button is expected. But the 2nd issue is not. Do you agree?

Yep! that sounds fair to me :)

Comment 5

[Niklas Baumgardner [:niklas]]

The patch in bug changes how focus works with regards to the screenshots UI so just adding as a see also