1874581 - Crash in [@ neqo_common::hrtime::Time::stop] -- assertion

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

50 crashes per week. Every crash has "assertion failed: (left == right) left: 0, right: 97 " -- the fact that the active period is always 97 when it should be 0 is likely an indicator

Crash report: https://crash-stats.mozilla.org/report/index/99fdae73-eca7-43a8-984e-c26b10240112

MOZ_CRASH Reason: ```assertion failed: (left == right)
left: `0`,
right: `97````

Top 10 frames of crashing thread:

0  xul.dll  MOZ_Crash  mfbt/Assertions.h:264
0  xul.dll  RustMozCrash  mozglue/static/rust/wrappers.cpp:17
1  xul.dll  mozglue_static::panic_hook  mozglue/static/rust/lib.rs:96
2  xul.dll  core::ops::function::Fn::call<void   /rustc/84c898d65adf2f39a5a98507f1fe0ce10a2b8dbc/library/core/src/ops/function.rs:166
3  xul.dll  alloc::boxed::impl$47::call  library/alloc/src/boxed.rs:2001
3  xul.dll  std::panicking::rust_panic_with_hook  library/std/src/panicking.rs:696
4  xul.dll  std::panicking::begin_panic_handler::closure$0  library/std/src/panicking.rs:583
5  xul.dll  std::sys_common::backtrace::__rust_end_short_backtrace<std::panicking::begin_panic_handler::closure_env$0, never$>  library/std/src/sys_common/backtrace.rs:150
6  xul.dll  std::panicking::begin_panic_handler  library/std/src/panicking.rs:579
7  xul.dll  core::panicking::panic_fmt  library/core/src/panicking.rs:64

Comment 2

[Valentin Gosu [:valentin]]

10 xul.dll neqo_common::hrtime::Time::stop() third_party/rust/neqo-common/src/hrtime.rs:311 cfi
11 xul.dll neqo_common::hrtime::Time::update() third_party/rust/neqo-common/src/hrtime.rs:319 cfi
12 xul.dll neqo_common::hrtime::Time::remove(neqo_common::hrtime::Period) third_party/rust/neqo-common/src/hrtime.rs:332 inlined
12 xul.dll neqo_common::hrtime::impl$4::drop(neqo_common::hrtime::Handle*) third_party/rust/neqo-common/src/hrtime.rs:260 cfi
14 xul.dll neqo_glue::neqo_http3conn_release(neqo_glue::NeqoHttp3Conn*) netwerk/socket/neqo_glue/src/lib.rs:218 cfi

I think this is probably harmless, but maybe Kershaw can take a quick look,

Comment 3

[Kershaw Chang [:kershaw]]

I've created a PR for this.

Comment 4

[Kershaw Chang [:kershaw]]

Fixed by bug 1877942.