1874648 - 3.55 - 2.25% damp console.typing / damp console.autocomplete.longInput + 3 more (Windows) regression on Thu January 11 2024

Status: NEW

(DevTools :: Inspector: Rules, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Perfherder has detected a devtools performance regression from push 9e9da9a3335070604e4d44a2a97d897ca73a4c16. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
4%	damp console.typing	windows10-64-shippable-qr	e10s fission stylo webrender-sw	376.16 -> 389.50
3%	damp console.autocomplete	windows10-64-shippable-qr	e10s fission stylo webrender-sw	563.69 -> 582.57
3%	damp console.autocomplete	windows10-64-shippable-qr	e10s fission stylo webrender	564.13 -> 582.96
2%	damp console.autocomplete.longInput	windows10-64-shippable-qr	e10s fission stylo webrender-sw	759.40 -> 778.34
2%	damp console.autocomplete.longInput	windows10-64-shippable-qr	e10s fission stylo webrender	760.17 -> 777.26

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 40993

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1872997

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Arai, is jsparsagous used in devtools somehow?

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Ah the pushlog in comment 0 seems wrong. Nicolas is that intentional? Which of the patches in bug 1872997 caused this?

Comment 4

[Tooru Fujisawa [:arai]]

jsparagus is disabled.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

when looking at this graph , I felt like
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b8e950d567b0591ee1f6ae0166466f99dd36f6e2&tochange=14ee45237cd8c3ca0bb75133c3d2a5b650c84e62 was a good candidate

Comment 6

[Bob Hood [:bhood]]

Can we get a Severity applied to this report, please?

Also, since soft freeze is coming up this Thursday, are we concerned at all about this entering Beta with Fx123?

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Bob Hood [:bhood] from comment #6)

Can we get a Severity applied to this report, please?

sure

Also, since soft freeze is coming up this Thursday, are we concerned at all about this entering Beta with Fx123?

no, this is fine