187466 - Dialog buttons too close to content above them in classic

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[piers]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021228 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021228 Phoenix/0.5

When using the Classic skin, the buttons at the bottom of most dialogs (e.g.
[Ok], [Cancel], etc.) are squashed up to the content above. These dialogs
include cookie manager, image manager, bookmark properties, password manager
(and probably more). In some instances this doesn't happen, e.g. in Page Setup
where the author has put a <seperator/> at the end of the xul file.

Reproducible: Always

Steps to Reproduce:
1. Switch to "Classic";
2. Go to Tools -> Image Manager -> Manage Image Permissions

Actual Results:  
The Close and Help buttons at the bottom of the dialog are squashed up to the
tabbox.

Expected Results:  
Spacing between the tabbox and buttons.

Comment 1

[piers]

Attachment: Patch to add margin-top to a dialog button

Add 5px margin to space the buttons.

Comment 2

[piers]

Attachment: Screenshot before and after patch

Comment 3

[:deanis74]

Comment on attachment 110510 [details] [diff] [review]
Patch to add margin-top to a dialog button

This is also going to affect buttons in dialogs other than those along the
bottom of the window, is it not?

Comment 4

[piers]

Isn't the definition of a "dialog-button" that the buttons have to be along the
 bottom? (i may be wrong here...) Could you give me an example of where a dialog
 button is used elsewhere.

Buttons in a dialog that aren't dialog-button's don't get affected (they are just 
button's).

Comment 5

[:deanis74]

Comment on attachment 110510 [details] [diff] [review]
Patch to add margin-top to a dialog button

Actually, I think you're right. r=me

Comment 6

[[e-mail]]

Don't forget to remove those <separator class="thin"/>s, for example in
commonDialog.xul!

Comment 7

[piers]

Yeah, there's quite a few of these that need doing (like in Page Setup), but i'll 
open a new bug on those once this is in.

This is The Right Way(tm) :)

Comment 8

[piers]

Checked in, but with 18px gap on Mac OS as per the Aqua examples:

http://developer.apple.com/techpubs/macosx/Essentials/AquaHIGuidelines/AHIGLayout/Sample_Dialog_Layouts.html

Marking fixed.

Comment 9

[Grace Bush]

verified 4/7 builds, classic theme - all platforms