Closed Bug 1874696 Opened 6 months ago Closed 6 months ago

Address performance issue related to `isInRemovedId` is messages reducer

Categories

(DevTools :: Console, enhancement)

enhancement

Tracking

(firefox123 fixed)

RESOLVED FIXED
123 Branch
Tracking Status
firefox123 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(2 files)

DAMP tests weren't logging enough messages to reach the maximum number of displayed messages,
which is currently set to 10k. Some extra computation happens to prune old, removed messages
which appear to be sometime slow.

Also log many messages during the batch iteration so that we removes lots of messages
on each new console update.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED

As we are only doing inclusion test, and this dataset is often large,
this will be signficantly faster.

Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef4ab841de82
[devtools] Better cover webconsole when reaching the maximum number of logged messages (10k). r=devtools-reviewers,perftest-reviewers,nchevobbe,sparky
https://hg.mozilla.org/integration/autoland/rev/91b8506ce5af
[devtools] Use a Set (instead of Array) for removed message IDs. r=devtools-reviewers,nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
Regressions: 1875474
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: