1874696 - Address performance issue related to `isInRemovedId` is messages reducer

Status: RESOLVED FIXED

(DevTools :: Console, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Let's try to address bug 1873066's issue specific to isInRemovedId first:
https://searchfox.org/mozilla-central/rev/6321fb8f7533456a62dfa2aa68ee0477a6c8f693/devtools/client/webconsole/reducers/messages.js#987

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1874696 - [devtools] Better cover webconsole when reaching the maximum number of logged messages (10k).

DAMP tests weren't logging enough messages to reach the maximum number of displayed messages,
which is currently set to 10k. Some extra computation happens to prune old, removed messages
which appear to be sometime slow.

Also log many messages during the batch iteration so that we removes lots of messages
on each new console update.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1874696 - [devtools] Use a Set (instead of Array) for removed message IDs.

As we are only doing inclusion test, and this dataset is often large,
this will be signficantly faster.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef4ab841de82
[devtools] Better cover webconsole when reaching the maximum number of logged messages (10k). r=devtools-reviewers,perftest-reviewers,nchevobbe,sparky
https://hg.mozilla.org/integration/autoland/rev/91b8506ce5af
[devtools] Use a Set (instead of Array) for removed message IDs. r=devtools-reviewers,nchevobbe

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ef4ab841de82
https://hg.mozilla.org/mozilla-central/rev/91b8506ce5af