1874748 - [wpt-sync] Sync PR 44004 - [WebDriver BiDi] Add tests for `browsingContext.close` for `promptUnload`

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44004 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44004
Details from upstream follow.

Nikolay Vitkov <[e-mail]> wrote:

[WebDriver BiDi] Add tests for browsingContext.close for promptUnload

Add the scaffolding and test for browsingContext.close for parameter promptUnload.
PR does not cover testing subframes that have beforeunload handlers (feature PR).

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f724632335d14813e2c955a237c04996ec5edd34

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 6 subtests

Status Summary

Firefox

OK : 2
PASS : 15[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 17[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]
FAIL : 2

Chrome

OK : 1
PASS : 11
TIMEOUT: 1

Safari

OK : 2
ERROR : 17

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webdriver/tests/bidi/browsing_context/close/prompt_unload.py [wpt.fyi]
  • test_prompt_unload_triggering_dialog[window]: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] (Safari: ERROR)
  • test_prompt_unload_triggering_dialog[tab]: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] (Safari: ERROR)

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This newly added test file /webdriver/tests/bidi/browsing_context/close/prompt_unload.py is actually causing a hang in Firefox. I'll take a look once it has been merged to mozilla-central.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f89ffc3da9e
[wpt PR 44004] - [WebDriver BiDi] Add tests for `browsingContext.close` for `promptUnload`, a=testonly
https://hg.mozilla.org/integration/autoland/rev/24d40aeb3ed0
[wpt PR 44004] - Update wpt metadata, a=testonly

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4f89ffc3da9e
https://hg.mozilla.org/mozilla-central/rev/24d40aeb3ed0

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #3)

This newly added test file /webdriver/tests/bidi/browsing_context/close/prompt_unload.py is actually causing a hang in Firefox. I'll take a look once it has been merged to mozilla-central.

I can no longer reproduce this issue with the test. It looks like I made a mistake in my patch for the handler field.