1874920 - Add "userContext" field to "browsingContext.Info" type

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

The PR adding support for user contexts also adds a new userContext field to browsingContext.Info, which is used for the payload of various events and commands of the browsingContext module.

Comment 1

[Julian Descottes [:jdescottes]]

At the moment, the main way to retrieve the userContext for a BrowsingContext is to check the usercontextid attribute on the embedderElement. While this is fine for browsingContext.contextCreated and browsingContext.getTree, it won't work for browsingContext.contextDestroyed because the embedder element will no longer be defined on a deleted browsing context.

Either we can get the information to be stored on the browsing context or we will need to do something similar to what we did for navigable ids in Bug 1694390, ie keep track of a map between navigables and user context ids.

Comment 2

[Julian Descottes [:jdescottes]]

Olli, do you know if we could have the user context id information directly set on the browsing context, to avoid reading it from the embedderElement?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Where do we need this information? Can we get it from WindowGlobal's principal?

Comment 4

[Julian Descottes [:jdescottes]]

(In reply to Olli Pettay [:smaug][[e-mail]] from comment #3)

Where do we need this information? Can we get it from WindowGlobal's principal?

From the parent process, but you're right this is available on the principal and this seems to work fine even when destroying the context. Thanks for the pointer!

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874920 - [bidi] Add userContext field to browsingContext.Info

Depends on D200023

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874920 - [wdspec] Add type hint parameter for context_created and context_destroyed user context tests

Depends on D200028

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874920 - [wdspec] Always assert user context in assert_browsing_context

Depends on D200032

This should ensure good coverage of the user_context field

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874920 - [wdspec] Add various user_context tests for browsingContext.create

Depends on D200181

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874920 - [bidi] Avoid using internal user context id in bidi modules

Depends on D200182

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab9c141ac485
[bidi] Add userContext field to browsingContext.Info r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/0237b0c99f39
[wdspec] Add type hint parameter for context_created and context_destroyed user context tests r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/8a66a3b89c40
[wdspec] Always assert user context in assert_browsing_context r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/1c00d395406f
[wdspec] Add various user_context tests for browsingContext.create r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/246fa8615ed5
[bidi] Avoid using internal user context id in bidi modules r=webdriver-reviewers,whimboo

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44418 for changes under testing/web-platform/tests

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ab9c141ac485
https://hg.mozilla.org/mozilla-central/rev/0237b0c99f39
https://hg.mozilla.org/mozilla-central/rev/8a66a3b89c40
https://hg.mozilla.org/mozilla-central/rev/1c00d395406f
https://hg.mozilla.org/mozilla-central/rev/246fa8615ed5

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24ad3719a4b9
[wpt PR 44418] - [Gecko Bug 1874920] [wdspec] Add type hint parameter for context_created and context_destroyed user context tests, a=testonly

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/24ad3719a4b9