Add "userContext" field to "browsingContext.Info" type
Categories
(Remote Protocol :: WebDriver BiDi, task, P2)
Tracking
(firefox124 fixed)
Tracking | Status | |
---|---|---|
firefox124 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 2 open bugs, )
Details
(Whiteboard: [webdriver:m10][wptsync upstream][webdriver:relnote])
Attachments
(5 files)
The PR adding support for user contexts also adds a new userContext
field to browsingContext.Info
, which is used for the payload of various events and commands of the browsingContext module.
Updated•11 months ago
|
Assignee | ||
Comment 1•11 months ago
•
|
||
At the moment, the main way to retrieve the userContext for a BrowsingContext is to check the usercontextid attribute on the embedderElement. While this is fine for browsingContext.contextCreated and browsingContext.getTree, it won't work for browsingContext.contextDestroyed because the embedder element will no longer be defined on a deleted browsing context.
Either we can get the information to be stored on the browsing context or we will need to do something similar to what we did for navigable ids in Bug 1694390, ie keep track of a map between navigables and user context ids.
Assignee | ||
Comment 2•11 months ago
|
||
Olli, do you know if we could have the user context id information directly set on the browsing context, to avoid reading it from the embedderElement?
Assignee | ||
Updated•11 months ago
|
Comment 3•11 months ago
|
||
Where do we need this information? Can we get it from WindowGlobal's principal?
Assignee | ||
Comment 4•11 months ago
|
||
(In reply to Olli Pettay [:smaug][bugs@pettay.fi] from comment #3)
Where do we need this information? Can we get it from WindowGlobal's principal?
From the parent process, but you're right this is available on the principal and this seems to work fine even when destroying the context. Thanks for the pointer!
Assignee | ||
Updated•11 months ago
|
Assignee | ||
Comment 5•10 months ago
|
||
Depends on D200023
Updated•10 months ago
|
Assignee | ||
Comment 6•10 months ago
|
||
Depends on D200028
Assignee | ||
Comment 7•10 months ago
|
||
Depends on D200032
This should ensure good coverage of the user_context field
Assignee | ||
Comment 8•10 months ago
|
||
Depends on D200181
Updated•10 months ago
|
Assignee | ||
Comment 9•10 months ago
|
||
Depends on D200182
Comment 10•10 months ago
|
||
Updated•10 months ago
|
Comment 13•10 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ab9c141ac485
https://hg.mozilla.org/mozilla-central/rev/0237b0c99f39
https://hg.mozilla.org/mozilla-central/rev/8a66a3b89c40
https://hg.mozilla.org/mozilla-central/rev/1c00d395406f
https://hg.mozilla.org/mozilla-central/rev/246fa8615ed5
Comment 15•10 months ago
|
||
Comment 16•10 months ago
|
||
bugherder |
Updated•9 months ago
|
Description
•