Closed Bug 1874982 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 44027 - [lint] Ban multiple `/resources/testharness{,report}.js` for `.js` tests

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox123 fixed)

Status:
RESOLVED FIXED
Milestone:
123 Branch
Tracking Flags:
Tracking Status
firefox123 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 44027 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44027
Details from upstream follow.

Jonathan Lee <jonathanjlee@google.com> wrote:

[lint] Ban multiple /resources/testharness{,report}.js for .js tests

wptserve already injects <script src="/resources/testharness.js"> into the boilerplate markup, so // META: script=... to do the same is redundant and should be disallowed by wpt lint.

wpt lint should also check script metadata for .window.js tests. Following up on #43984, clean up this and other latent lint errors.

See Also: https://crbug.com/1518022

PR 44027 applied with additional changes from upstream: 2f9396a79dff547231354b2cded2d5c47b05095c

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS : 3
TIMEOUT: 1[Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-opt] 2[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug, GitHub]
ERROR : 1

Chrome

OK : 2
PASS : 3
FAIL : 1

Safari

OK : 1
PASS : 3
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /performance-timeline/not-restored-reasons/abort-block-bfcache.window.html [wpt.fyi]: ERROR [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], TIMEOUT [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: OK, Safari: ERROR)
    • aborting a parser should block bfcache.: TIMEOUT (Chrome: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f4f1baecbee [wpt PR 44027] - [lint] Ban multiple `/resources/testharness{,report}.js` for `.js` tests, a=testonly https://hg.mozilla.org/integration/autoland/rev/8d40596abaec [wpt PR 44027] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/7f4f1baecbee
https://hg.mozilla.org/mozilla-central/rev/8d40596abaec

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox123: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.