selectedIndex broken for <tabs> element

RESOLVED FIXED

Status

()

RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: rginda, Assigned: jag-mozilla)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

616 bytes, patch
bugzilla
: review+
jag-mozilla
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
The selectedIndex property of the <tabs> element is busted, as of version 1.4 of
tabbox.xml.

It checks tabs.selected, instead of tabs[i].selected.  This breaks Venkman, and
probably a few other things.
(Reporter)

Comment 1

16 years ago
Created attachment 110535 [details] [diff] [review]
patch
(Reporter)

Updated

16 years ago
Attachment #110535 - Flags: superreview?(jaggernaut)
Attachment #110535 - Flags: review?(blaker)
(Assignee)

Comment 2

16 years ago
Comment on attachment 110535 [details] [diff] [review]
patch

Oops. sr=jag
Attachment #110535 - Flags: superreview?(jaggernaut) → superreview+

Comment 3

16 years ago
Comment on attachment 110535 [details] [diff] [review]
patch

doh
Attachment #110535 - Flags: review?(blaker) → review+
(Reporter)

Comment 4

16 years ago
You may not check into partition Browser
the file mozilla/toolkit/content/widgets/tabbox.xml on branch HEAD
If you think you should be allowed to, send mail to
one of the below people:
  dean_tessman@hotmail.com
  hewitt@netscape.com
  chanial@noos.fr
  blakeross@telocity.com
  hyatt@apple.com

Well then.  Blake, you want to check this in?
(Assignee)

Comment 5

16 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.