1875040 - about:blank is created when we check CanSavePresentation

Status: RESOLVED WONTFIX

(Core :: DOM: Navigation, defect)

Comment 1

[Andreas Farre [:farre]]

Try run

Comment 2

[Andreas Farre [:farre]]

Attachment: Bug 1875040 - Use GetExtantDocument instead of GetDocument. r=smaug!

Avoids accidentally creating a document when checking if a document's
presentation can be saved.

Comment 3

[Andreas Farre [:farre]]

Try looks good, with the exception of a permafail at:

remote/cdp/test/browser/network/browser_navigationEvents.js
  FAIL Page.frameAttached(10737418241) received before Network.requestWillBeSent(Subdocument)) -

Comment 4

[Andreas Farre [:farre]]

Attachment: Bug 1875040 - [cdp] Remove Fission specific cases from context observer. r=whimboo!

The document requiring the special casing is no longer created, so the
special case can go away.

Depends on D198781

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e77ff8e2bfc
Use GetExtantDocument instead of GetDocument. r=smaug
https://hg.mozilla.org/integration/autoland/rev/8af7503ecb57
[cdp] Remove Fission specific cases from context observer. r=whimboo,webdriver-reviewers

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/0e77ff8e2bfc
https://hg.mozilla.org/mozilla-central/rev/8af7503ecb57

Comment 7

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e77ff8e2bfc
Use GetExtantDocument instead of GetDocument. r=smaug
https://hg.mozilla.org/integration/autoland/rev/8af7503ecb57
[cdp] Remove Fission specific cases from context observer.
r=whimboo,webdriver-reviewers

== Change summary for alert #41281 (as of Fri, 02 Feb 2024 03:50:25 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
9%	cross_origin_pageload	windows10-64-shippable-qr	e10s fission stylo webrender-sw	261.33 -> 239.00
8%	cross_origin_pageload	windows10-64-shippable-qr	e10s fission stylo webrender-sw	260.98 -> 239.78
8%	cross_origin_pageload	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	250.84 -> 230.53
8%	cross_origin_pageload	windows10-64-shippable-qr	e10s fission stylo webrender	261.58 -> 240.69
6%	cross_origin_pageload	linux1804-64-shippable-qr	e10s fission stylo webrender	255.62 -> 239.72

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=41281

Comment 8

[Iulian Moraru]

Backed out 2 changesets (bug 1875040) for causing performance regression - Bug 1877481.

• Push that was backed out

• Backout link

Comment 9

[Sandor Molnar[:smolnar]]

Backout merged to central:

https://hg.mozilla.org/mozilla-central/rev/54bf47d03582

Comment 10

[Alex Finder]

(In reply to Iulian Moraru from comment #8)

Backed out 2 changesets (bug 1875040) for causing performance regression - Bug 1877481.

• Push that was backed out

• Backout link

== Change summary for alert #41520 (as of Tue, 20 Feb 2024 10:11:52 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
14%	espn PerceptualSpeedIndex	linux1804-64-shippable-qr	cold fission webrender	886.95 -> 765.52	Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=41520

Comment 11

[Andrej (:aglavic)]

(In reply to Iulian Moraru from comment #8)

Backed out 2 changesets (bug 1875040) for causing performance regression - Bug 1877481.

• Push that was backed out

• Backout link

The backout has reverted some previous performance improvements we detected:
== Change summary for alert #41514 (as of Tue, 20 Feb 2024 07:47:14 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
9%	cross_origin_pageload	windows10-64-shippable-qr	e10s fission stylo webrender-sw	242.27 -> 263.44
8%	cross_origin_pageload	windows10-64-shippable-qr	e10s fission stylo webrender	242.05 -> 261.57
8%	cross_origin_pageload	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	225.16 -> 243.02
7%	cross_origin_pageload	linux1804-64-shippable-qr	e10s fission stylo webrender	234.31 -> 251.18
7%	cross_origin_pageload	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	229.27 -> 245.29

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=41514

Comment 12

[Andreas Farre [:farre]]

Yeah, this regression is expected when backing out this patch. Nothing to be done about that unfortunately.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:farre, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 14

[Andreas Farre [:farre]]

Even though this patch is morally right, the effort to fix performance regressions is too high. The current state is good enough.