Simplify OpenSearchEngine loading and install process in the search service
Categories
(Firefox :: Search, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | verified |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
Currently, when adding an OpenSearch based engine, the search service creates the engine and loads data into it. Once the data is loaded, the engine notifies the search service, which then adds it to the store.
We can simplify this, by having the search service load the data, initialise the engine and then add it to its own store.
This will also mean that we don't need the shouldPersist parameter to OpenSearchEngine as the place where it is used (contextual search), can load the data and initialise the engine directly without it needing to go through the search service.
|
Assignee | |
Comment 1•1 year ago
|
||
The current process creates the OpenSearchEngine and gets it to load its data. Once the data is loaded,
it notifies the SearchService that is ready to be added.
This changes the structure so that the SearchService loads the data, creates the engine and then adds it
straight away.
This also means that the contextual search provider can be simplified and doesn't need to tell the engine
not to add itself to the SearchService.
Depends on D198723
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 4•1 year ago
|
||
For QE verify, this is about checking the installation process again. Similar to bug 1822097, but this was a more complex change that ended up landing in 124. Both address bar & search bar installation routes should be checked.
Verified as fixed using Nightly 124.0a1 2024-01-29 under Win 11, Ubuntu 22 and macOSX 12. No issues were identified while installing OpenSearch engines.
Description
•