1875085 - [Android] Allow to fallback to type hint "tab" in "WebDriver:NewWindow` command

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Right now we do not allow to fallback to the type hint of tab if window is specified for WebDriver:NewWindow on Android even through it is up to the implementation as specified under point 5 in the WebDriver classic spec:

In all other cases the details of how the browsing context is presented to the user are implementation defined.

Also Wdspec tests for Chrome on Android is passing them all.

This means we can remove a lot of expected fail / skip entries from Wdspec manifest files.

Note that there might be strict equality checks for the type hint in some tests. We may have to slightly stretch these.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1875085 - [marionette] Fallback to type hint "tab" in "WebDriver:NewWindow` on Android when "window" is specified.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1875085 - [wdspec] Fix assertion for type hint when opening a new window on Android.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Lets wait for the upstream test to get reviewed and merged via bug 1876049.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5977bb53a4c
[marionette] Fallback to type hint "tab" in "WebDriver:NewWindow` on Android when "window" is specified. r=webdriver-reviewers,jdescottes

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b5977bb53a4c