1875091 - Display WDBA notification using ASRouter trigger

Status: NEW

(Toolkit :: Default Browser Agent, enhancement, P3)

Description

[Nick Alexander :nalexander [he/him]]

This ticket tracks using ASRouter to display the WDBA notification. This is part of the boilerplate required to make the notification data-driven and eventually remotely controlled via Nimbus.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: WIP: Bug 1875091 - WIP on using ASRouter to display messages in WDBA.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: WIP: Bug 1875091 - Pre: Add `--no-telemetry` to WDBA to not send telemetry.

Depends on D198817

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: WIP: Bug 1875091 - WIP on relaunching `firefox --backgroundtask ...` via notification server.

This isn't ready because --backgroundtask backgroundupdate does not
yet handle this relaunch.

Depends on D198818

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: WIP: Bug 1875091 - WIP on through-hacking the ASRouter into WDBA.

This registers the OnboardingMessageProvider for local messages, and
uses ASRouter to pop the notification, but it doesn't set up the
notification observer and it doesn't actually handle the relaunch (via
the remote protocol, eventually).

Depends on D198819

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: WIP: Bug 1875091 - Pre: No `-no-remote` in `./mach run -- --backgroundtask ...`. r?#build

This is simply a convenience: backgroundtasks are short-lived and
don't generally want a -no-remote argument to avoid re-using
instances during development.

Comment 6

[Nick Alexander :nalexander [he/him]]

Attachment: WIP: Bug 1875091 - Pre: Avoid a `TelemetryUtils` exception in background task mode.

There's no browsing session and subsession in background task mode, so
avoid asking for session metadata and throwing an obscure date-parsing
exception.

Depends on D199148

Comment 7

[Nick Alexander :nalexander [he/him]]

Attachment: WIP: Bug 1875091 - Pre: No `-no-remote` in `./mach run -- --backgroundtask ...`. r?#build

This is simply a convenience: backgroundtasks are short-lived and
don't generally want a -no-remote argument to avoid re-using
instances during development.

Comment 8

[Nick Alexander :nalexander [he/him]]

Attachment: WIP: Bug 1875091 - Pre: Avoid a `TelemetryUtils` exception in background task mode.

There's no browsing session and subsession in background task mode, so
avoid asking for session metadata and throwing an obscure date-parsing
exception.

Depends on D199151

Comment 9

[Nick Alexander :nalexander [he/him]]

Attachment: WIP: Bug 1875091 - Pre: Allow remote protocol in `--backgroundtask` mode. r?nrishel

This was disabled out of an abundance of caution: the last thing we
want is a (long-lived) background task trying to open links for
browsing, for example.

However, the remote protocol is what the notificationserver.dll
relies on under Windows to ferry a notification interaction to a
running Firefox. We need it to handle notifications in background
tasks.

There should be no interaction between browsing windows and background
tasks because the "class name" used to identify candidate instances to the
remote protocol includes the relevant profile (see
https://searchfox.org/mozilla-central/rev/9c65def36af441133c75a44b126e65184b039b2f/toolkit/components/remote/RemoteUtils.h#15),
and will avoid "cross-talk" of this sort.

Depends on D199153

Comment 10

[Phabricator Automation]

Comment on attachment 9375545 [details]
WIP: Bug 1875091 - Pre: Avoid a TelemetryUtils exception in background task mode.

Revision D199152 was moved to bug 1875907. Setting attachment 9375545 [details] to obsolete.