1875189 - Editorial fixups to WPT getClientRects-zoom.html

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, task)

Description

[Daniel Holbert [:dholbert]]

This is similar to bug 1874986, but to fix cosmetic/parsing issues for WPT getClientRects-zoom.html.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of the test results section on wpt.live (Firefox on left with passes, chrome on right with failures)

To illustrate the utility of the fixes here, here's how this test looks at wpt.live right now (before the fixups) -- the test results are unreadable.

(Firefox is on the left; we happen to pass all the subtests. Chrome is on the right; they fail some subtests. The pass/fail output is impossible to read since it's all squished due to a misapplied css rule that's meant for test content.)

Live link: http://wpt.live/css/cssom-view/getClientRects-zoom.html

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1875189: Fixups for nits/cosmetic issues in WPT getClientRects-zoom.html. r?TYLin

This patch doesn't change the behavior (or pass/fail status) of the test at
all; it's just fixing some issues in the test that trigger parser errors and/or
make the test results hard to read.

(This is very similar to the patch that I landed earlier in
https://bugzilla.mozilla.org/show_bug.cgi?id=1874986 ; this one's just for
a different test that had similar issues.)

Specific fixes here:

• Removing the 'head' element since it's unnecessary and was being opened later
  than appropriate (after head content had already begun).
• Wrapping the test content in an element that we can use to scope the rules,
  so that we don't end up with a generic 'div' css selector that inadvertently
  targets the test-results divs that the harness appends to the page.
• Remove a stray backtick at the end of the file, and add a final newline.
• Indentation changes to remove unnecessary indentation and to accommodate the
  newly-added "test_content" wrapper div.

Comment 3

[Daniel Holbert [:dholbert]]

+CC christhtr and yotha, reviewer/author of these test in question in this bug and bug bug 1874986 (in https://chromium-review.googlesource.com/c/chromium/src/+/5190711 ). Hope you folks don't mind these fixup tweaks.

See pre-fixup screenshots of this bug's test and the other bug's test and the patches on the two bugs. Could you add "watch out for CSS rules that might inadvertently target the test-results section" to your checklist of things to watch for when writing/reviewing WPTs? Thanks! :) (See the patches for various other drive-by fixups in for other minor things to watch out for too.)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27eff41c0d1c
Fixups for nits/cosmetic issues in WPT getClientRects-zoom.html. r=TYLin

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44057 for changes under testing/web-platform/tests

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/27eff41c0d1c

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot