1875225 - InputEncoding is incorrect on yahoo-jp-auctions.xml and rakuten.xml

Status: RESOLVED FIXED

(Firefox for Android :: Search, defect)

Description

[Makoto Kato [:m_kato]]

Steps to reproduce

1. Input search words with Rakuten (楽天市場) in address bar

Expected behavior

Search works with inputted word.

Actual behavior

Search word is corrupted.

Any additional information?

These search plugins seem to be added by bug 1858528. But InputEncoding is incorrect.

Comment 1

[Makoto Kato [:m_kato]]

Also, I guess SearchEngineReader doesn't check InputEncoding element too... Oh

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1858528

:skhan, since you are the author of the regressor, bug 1858528, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1875225 - Search terms are corrupted when using some search plugins (#5200)

Comment 4

[Donal Meehan [:dmeehan]]

:skhan/:m_kato could this be triaged?
We could include this in the planned Fenix Fx122 dot release scheduled for 2024-01-30 (dependant on risk, etc.)

Comment 5

[Makoto Kato [:m_kato]]

(In reply to Donal Meehan [:dmeehan] from comment #4)

:skhan/:m_kato could this be triaged?
We could include this in the planned Fenix Fx122 dot release scheduled for 2024-01-30 (dependant on risk, etc.)

This is real P1 bug. Both search plugins that are landed are broken. Also, my understand is that Mozilla has affiliate contract with both companies. This should be landed in release channel.

Comment 6

[Mike Kaply [:mkaply]]

So if this had been reported when we first shipped it (Firefox 121), I would probably go with P1, but since it hasn't been found by many folks (yet), I think it's probably a P2, but if we can get a fix in the dot release, I would be very happy with that.

I've reached out to folks.

Comment 7

[Roger Yang [:royang]]

:dmeehan, the plan is to land the fix :m_kato implemented right after the v123 cut so we can have the fix first verified by QA. Once QA verified the fix and we've soaked it in Nightly to confirm no issues, we'll then uplift to Beta to soak there.

Comment 8

[BMO Github Automation]

Authored by https://github.com/makotokato
https://github.com/mozilla-mobile/firefox-android/commit/d793f928210031d9cc7bdd810ef3fcb638687410
[main] Bug 1875225 - Part 1. Support <InputEncoding> element in search plugin.

Authored by https://github.com/makotokato
https://github.com/mozilla-mobile/firefox-android/commit/31bf9dcf6fc21bcb75c0f4d84202dc00416cf6e8
[main] Bug 1875225 - Part 2. Use valid InputEnconding element for Rakuten and Yahoo! Japan Auctions.

Comment 9

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1875225 - Search terms are corrupted when using some search plugins (backport #5200) (#5274)

Comment 10

[Makoto Kato [:m_kato]]

Comment on attachment 9376183 [details] [review]
[mozilla-mobile/firefox-android] Bug 1875225 - Search terms are corrupted when using some search plugins (backport #5200) (#5274)

Beta/Release Uplift Approval Request

• User impact if declined: When using Rakuten or Yahoo! Japan Auction search plugin from address bar, search terms are corrupted.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low. We uses correct character encoding that is not UTF-8.
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1875225 - Search terms are corrupted when using some search plugins (backport #5200) (#5275)

Comment 12

[Makoto Kato [:m_kato]]

Comment on attachment 9376190 [details] [review]
[mozilla-mobile/firefox-android] Bug 1875225 - Search terms are corrupted when using some search plugins (backport #5200) (#5275)

Beta/Release Uplift Approval Request

• User impact if declined: When using Rakuten or Yahoo! Japan Auction search plugin from address bar, search terms are corrupted.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low. We use correct character encoding that is not UTF-8.
• String changes made/needed: No
• Is Android affected?: Yes

Comment 13

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

Comment on attachment 9376183 [details] [review]
[mozilla-mobile/firefox-android] Bug 1875225 - Search terms are corrupted when using some search plugins (backport #5200) (#5274)

Approved for 123 beta.

Comment 14

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/4e27125f4fd18b45f1243cf5ae37e09f693b79f0
[releases_v123] Bug 1875225 - Search terms are corrupted when using some search plugins (backport #5200) (#5274)

Comment 15

[Donal Meehan [:dmeehan]]

Comment on attachment 9376190 [details] [review]
[mozilla-mobile/firefox-android] Bug 1875225 - Search terms are corrupted when using some search plugins (backport #5200) (#5275)

Approved for Fenix/Focus 122.0.1

Comment 16

[BMO Github Automation]

Authored by https://github.com/makotokato
https://github.com/mozilla-mobile/firefox-android/commit/3783493cb2ba2d9c77068bd8f3eebeaac0292c48
[releases_v122] Bug 1875225 - Part 1. Support <InputEncoding> element in search plugin.

Authored by https://github.com/makotokato
https://github.com/mozilla-mobile/firefox-android/commit/71a1a7dac743af24ecfb128d0b03ea271b5cb8a9
[releases_v122] Bug 1875225 - Part 2. Use valid InputEnconding element for Rakuten and Yahoo! Japan Auctions.