Closed Bug 187529 Opened 23 years ago Closed 23 years ago

jsd init's a jscontext and doesn't release it (caught by res->input leak)

Categories

(Other Applications Graveyard :: Venkman JS Debugger, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file)

JS engine warning: leaking GC root 'res->input' at 151fe8 JS engine warning: 1 GC root remains after destroying the JSRuntime. This root may point to freed memory. Objects reachable through it have not been finalized. This is the stack: js_InitRegExpStatics(JSContext * 0x0097c7b0, JSRegExpStatics * 0x0097c860) line 2339 js_NewContext(JSRuntime * 0x014e3378, unsigned int 256) line 110 + 19 bytes JS_NewContext(JSRuntime * 0x014e3378, unsigned int 256) line 889 + 13 bytes _newJSDContext(JSRuntime * 0x014e3378, JSD_UserCallbacks * 0x00000000, void * 0x00000000) line 134 + 18 bytes jsd_DebuggerOnForUser(JSRuntime * 0x014e3378, JSD_UserCallbacks * 0x00000000, void * 0x00000000) line 195 + 17 bytes JSD_DebuggerOnForUser(JSRuntime * 0x014e3378, JSD_UserCallbacks * 0x00000000, void * 0x00000000) line 52 + 17 bytes jsdService::OnForRuntime(jsdService * const 0x0097a9a0, JSRuntime * 0x014e3378) line 2418 + 13 bytes jsdASObserver::Observe(jsdASObserver * const 0x0097aa60, nsISupports * 0x00000000, const char * 0x00537b6c, const unsigned short * 0x0054f0d4) line 3243 + 27 bytes XPCOM! 00480255() XPCOM! 0047c727() XPCOM! 0047d1bd() main(int 1, char * * 0x009543d0) line 865 mainCRTStartup() line 338 + 17 bytes KERNEL32! 77e87903() when i ran xpcshell, there were only two other res->input's created, one for xpcshell and one for xpconnect (after i quit()). steps: run xpcshell quit()
Attached patch draft — — Splinter Review
Attachment #110557 - Flags: review?(rginda)
Attachment #110557 - Flags: review?(rginda) → review+
Attachment #110557 - Flags: superreview+
checked in. qa note: verification is as simple as running xpcshell and typing "quit()<enter>" with jsd component present. the warning should appear in a tree from before the fix and should not appear in a tree from after the fix.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Product: Core → Other Applications
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: