1875325 - Large JPEG image attachments in received E-mail are not always resized to the window width.

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect, P2)

Description

[anacond71]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:121.0) Gecko/20100101 Firefox/121.0

Steps to reproduce:

1. I sent an E-mail to myself containing three JPEGs of 4-5 MBs each, as attachments (not inline).
2. I opened the E-Mail with the option "View" --> "Disable Attachments inline" enabled.

Actual results:

Only the first JPEG image was resized to the window width. The other two were displayed at 100% size (at about 72 dpi, so very large). The magnifying glass cursor only appeared on the first image. When I moved the mouse over the second or third image, the cursor didn't change to a magnifying glass.

Expected results:

All three images should have been resized to the window width.

Comment 1

[anacond71]

The three JPEG files I used can be downloaded from:

https://drive.google.com/file/d/1OmXMPUNHrR4ZZZO4beXeeCjZmt8QF-_P/view?usp=drive_link

Comment 2

[anacond71]

Attachment: The upper photo is resized correctly, the lower one isn't.

Comment 3

[anacond71]

The three JPEG files I used can be downloaded from:

https://drive.google.com/file/d/1OmXMPUNHrR4ZZZO4beXeeCjZmt8QF-_P/view?usp=sharing

Comment 4

[betterbird.project+14]

https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/NNN6-fix-image-overflowing.patch

Comment 5

[Chris Spangler]

Similar problem here with RSS feeds where images are embedded in the summary, since 115.5.2. On first load, the images are not scaled to message pane width, but on second load onwards, it works fine. Still occurs on latest commit, and the patch linked above does not work, as messagePaneOnResize is not called.

I've written a patch that instead attaches a load event listener to images, so the initial overflow check waits for the width to be known. This one works fine for my problem, I was also able to reproduce OP's problem using their files and it's fixed with this patch as well.

https://gist.github.com/Suyooo/15717aac4c4b9abeeecaee81624ee31c

Comment 8

[chrizilla]

See bug #1888802 for a very similar but slightly different description of the experienced phenomenon.

Workaround: Changing the window size (of the preview pane or the entire TB window) fits all the images.

Comment 10

[chrizilla]

also seems to happen with RSS feeds: bug 1905541

Comment 12

[Martin Giger [:freaktechnik]]

Attachment: Bug 1875325 - Fix image overflow handling in message reader. r=#thunderbird-front-end-reviewers

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3c3ca8ea292b
Fix image overflow handling in message reader. r=aleca