Ending punctuation missing in two a-c strings
Categories
(Firefox for Android :: General, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: lebedel.delphine, Assigned: avirvara)
Details
Attachments
(2 files)
-
String 1: "Reminder: %1$s is still using your microphone. Tap to open the tab"
String ID: mozac_feature_media_sharing_microphone_reminder_text
Issue: No punctuation at the end (period) -
String 2: "Reminder: %1$s is still using your microphone and camera. Tap to open the tab"
String ID: mozac_feature_media_sharing_camera_and_microphone_reminder_text
Issue: No punctuation at the end (period)
This is inconsistent with other similar strings that have landed at the same time. Talked with Emily Wachowiak and she confirmed these should have the ending punctuation.
ni: Alexandra-Virvara since it seems like you landed the strings (note, these are android-component strings). thanks!
|
||
Comment 1•2 years ago
|
||
|
|
||
Comment 2•2 years ago
|
||
Authored by https://github.com/Alexandra-Virvara
https://github.com/mozilla-mobile/firefox-android/commit/07be36fa8219f6c8d40d15f79975b76167edb3ef
[main] Bug 1875382: add ending punctuation
|
|
||
Comment 3•2 years ago
|
||
|
|
||
Comment 4•2 years ago
|
||
Authored by https://github.com/Alexandra-Virvara
https://github.com/mozilla-mobile/firefox-android/commit/92b8fddd9f40fcb54dcd5993f72bc5f62751b7e9
[main] Bug 1875382: add ending punctuation & change strings ids
|
Assignee | |
Updated•2 years ago
|
Description
•