1875486 - Save buttons are not dismissed on click selection on the about:crashes page

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect, P1)

Description

[Simona Badau, Desktop QA]

Attachment: Screenshot with the click selection and the Save buttons

Found in

• Nightly 123.0a1

Affected versions

• Nightly 123.0a1

Tested platforms

• Affected platforms: macOS 13, Ubuntu 22.04 x64

Preconditions

• 'screenshots.browser.component.enabled' is set to true in about:config

Steps to reproduce

1. Go to about:crashes
2. Enable Screenshots and do a click selection.

Expected result

• The Save buttons should be dismissed when the click selection is done.

Actual result

• The Save buttons are not dismissed when the click selection is done. Please see the screenshot for mode details.

Regression range

• This is not a regression, it's reproducible only when enabling the component version of Screenshots.

Comment 1

[Niklas Baumgardner [:niklas]]

The issue is that the ScreenshotsComponentChild is never receiving the Screenshots:HidePanel event

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1875486 - Use document to dispatch events for screenshots. r=sfoster

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1875486 - Rename dispatchEvent in crashes.js. r=gsvelto

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99c36b3fe9c3
Rename dispatchEvent in crashes.js. r=gsvelto

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/99c36b3fe9c3

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:niklas, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Simona Badau, Desktop QA]

Verified as fixed using the latest Nightly 124.0a1 on Windows 10x64, Ubuntu 22.04 and macOS 13.