1875565 - [wpt-sync] Sync PR 44097 - [FedCM] Check response code in Error API

Status: RESOLVED FIXED

(Core :: DOM: Credential Management, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44097 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44097
Details from upstream follow.

Yi Gu <[e-mail]> wrote:

[FedCM] Check response code in Error API

If an IdP returns unparsable response in the id assertion endpoint,
currently we treat it as a server error. Rather, we should only proceed
with server error if the response code is 500 or the IdP explicitly
uses "server_error" in the Error API.

Bug: 1519671
Change-Id: Ia671c25fdfc17763418b0ea29004137f2413e700
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5214925
Auto-Submit: Yi Gu \<[e-mail]>
Commit-Queue: Yi Gu \<[e-mail]>
Reviewed-by: Zachary Tan \<[e-mail]>
Commit-Queue: Zachary Tan \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1249557}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4802295b39e2358521f718353fd43716302e5565

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

TIMEOUT: 2
NOTRUN : 1

Chrome

TIMEOUT: 2
NOTRUN : 1

Safari

TIMEOUT: 1
ERROR : 1
NOTRUN : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /credential-management/fedcm-endpoint-redirects.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: ERROR)
  • Test that promise is rejected if accounts endpoint redirects: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • Test that token endpoint does not follow redirects: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)

Tests Disabled in Gecko Infrastructure

• /credential-management/fedcm-endpoint-redirects.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cab1fb06522d
[wpt PR 44097] - [FedCM] Check response code in Error API, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cab1fb06522d