1875590 - Addons have "download" button instead of "install" button

Status: RESOLVED INVALID

(Thunderbird :: Add-Ons: General, enhancement)

Description

[Amanita]

Steps to reproduce:

I have applied this hardening user.js to Thunderbird

https://github.com/HorlogeSkynet/thunderbird-user.js

But I disabled both RFP and

user_pref("privacy.resistFingerprinting.block_mozAddonManager", false)

So these changes do not apply. The origin profile was Vanilla and Addon installation worked normally here.

Actual results:

Now instead of "install" buttons I get "download" buttons.

I suppose this is what happens if
A: the browser has no addonmanager (already cancelled out that one)
B: it is not recognized as Thunderbird but Firefox maybe

Expected results:

I would like to find the issue for this error, as I would like to fix this hardening.

I understand that you may not want to preset many of the settings, and I will also create my own version as many are either already default (and limit user customization) or too harsh.

Comment 1

[Amanita]

https://github.com/HorlogeSkynet/thunderbird-user.js/issues/43

I already reported that bug, and I know this is not a general thunderbird bug. But I want to understand what causes it and fix the project.

Comment 2

[John Bieling]

I currently do not have resources to handle this, but happily accept patches.

Edit: But it looks intentional:
https://searchfox.org/mozilla-central/rev/6fadc18daffd3991c130f69b4dc79be8671299b4/toolkit/mozapps/extensions/AddonManagerWebAPI.cpp#39

Comment 3

[John Bieling]

I did a little more research. The addon-server (the ATN page loaded by the Thunderbird add-on manager) uses the mozAddonManager API to know if it is loaded by Thunderbird or not:
https://github.com/thunderbird/addons-server/blob/master/static/js/zamboni/buttons.js#L345

If you disable the mozAddonManager API in Thunderbird, this of course has to fail. The page then thinks it is loaded outside of Thunderbird.

I guess you cannot have both, and this is not broken, but intentional.

Comment 4

[Magnus Melin [:mkmelin]]

Agreed.