1875657 - Crash in [@ mozilla::Monitor::Lock]

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

Crash report: https://crash-stats.mozilla.org/report/index/894e7727-149b-4288-9acb-deac40240115

Reason: SIGSEGV / SEGV_MAPERR

Top 10 frames of crashing thread:

0  libc.so.6  ___pthread_mutex_lock  nptl/nptl/pthread_mutex_lock.c:80
1  firefox-bin  mozilla::detail::MutexImpl::mutexLock  mozglue/misc/Mutex_posix.cpp:94
1  firefox-bin  mozilla::detail::MutexImpl::lock  mozglue/misc/Mutex_posix.cpp:116
2  libxul.so  mozilla::OffTheBooksMutex::Lock  xpcom/threads/Mutex.h:66
2  libxul.so  mozilla::Monitor::Lock  xpcom/threads/Monitor.h:31
2  libxul.so  mozilla::detail::BaseMonitorAutoLock<mozilla::Monitor>::BaseMonitorAutoLock  xpcom/threads/Monitor.h:129
2  libxul.so  mozilla::layers::RemoteTextureMap::UnregisterTextureOwners  gfx/layers/RemoteTextureMap.cpp:696
3  libxul.so  mozilla::layers::RemoteTextureOwnerClient::UnregisterAllTextureOwners  gfx/layers/RemoteTextureMap.cpp:77
4  libxul.so  mozilla::layers::CanvasTranslator::ClearTextureInfo  gfx/layers/ipc/CanvasTranslator.cpp:1096
5  libxul.so  mozilla::detail::RunnableMethodArguments<>::apply<mozilla::layers::CanvasTranslator, void  const  xpcom/threads/nsThreadUtils.h:1164

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Looks like a shutdown crash, where the RemoteTextureMap is already gone away, while the CanvasTranslator has yet to go away.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Probably happens because of https://searchfox.org/mozilla-central/rev/85679f95a634d08307e115fb365ea287198bd4d2/gfx/layers/ipc/CanvasTranslator.cpp#359 dispatching after ActorDestroy is called.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1875657 - Ensure that we run CanvasTranslator::FinishShutdown without dispatching from task queue.

We need to complete shutdown synchronously from
CanvasTranslator::ActorDestroy as once it completes, we may destroy the
RemoteTextureMap.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0361c1f29bab
Ensure that we run CanvasTranslator::FinishShutdown without dispatching from task queue. r=gfx-reviewers,lsalzman

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0361c1f29bab