1875782 - windows lost on exit

Status: RESOLVED DUPLICATE of bug 1818971

(Firefox :: Session Restore, defect, P2)

Description

[keynet]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:121.0) Gecko/20100101 Firefox/121.0

Steps to reproduce:

Exit Firefox 121.01 while multiple windows open (set to retain windows)

Actual results:

When restarted, often 1 complete window will have disappeared. Does not appear in recently closed windows or tabs

Expected results:

Should remember all windows! I have 20, lose 1 typ lost per closure. Looks like an off-by-1 bug.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Win32' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Negritas Sergiu, Desktop QA]

Hello! Thank you for submitting this issue I have managed to reproduce the issue using firefox 124.0a1(2024-01-23), 123.0b1 and 122.0 on Ubuntu 22.04, Windows 10 and MacOS 12.6.

I will mark this issue as NEW in order to get our developers involved and provide a solution.

Have a nice day!

Comment 3

[Sam Foster [:sfoster] (he/him)]

(In reply to Negritas Sergiu, Desktop QA from comment #2)

Hello! Thank you for submitting this issue I have managed to reproduce the issue using firefox 124.0a1(2024-01-23), 123.0b1 and 122.0 on Ubuntu 22.04, Windows 10 and MacOS 12.6.

We do have logic that will discard apparently empty windows on exit, so to verify there is a bug here can you give some more detail on your STR? How many windows did you have open, and did those windows have tabs that weren't about:blank / about:home / about:newtab.

Comment 4

[keynet]

As mentioned in the OP, I have about 20 windows, and quite a few tabs each, number varies. My use case is a window per subject I'm multitasking on. If I lose one, that's a problem! I can confirm none were just blank or 'about... ', they are, as I say, all full of subject areas I'm researching.

Comment 5

[Negritas Sergiu, Desktop QA]

Hello Sam! I didn't open many windows somewhere around 10 windows and in each window was a different website and they weren't about:blank /about:home or about:newtab.

As steps to reproduce:

1. Enable or disable the "Open previous windows and tabs"
2. Open multiple windows with different webpages.
3. Close firefox from the start bar with right click and close.
4. Reopen firefox and restore the previous session.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sfoster, could you have a look please?

For more information, please visit BugBot documentation.

Comment 7

[Sam Foster [:sfoster] (he/him)]

1. Enable or disable the "Open previous windows and tabs"
2. Open multiple windows with different webpages.

Can you clarify exactly how many windows you used to reproduce this issue?

3. Close firefox from the start bar with right click and close.

I assume this means you reproduced on Windows?

Comment 8

[Negritas Sergiu, Desktop QA]

Hello Sam! As I mentioned in comment 2 I have managed to reproduce the issue with Windows 10, Ubuntu 22.04 and MacOS 12.6. I managed to reproduce the issue with 2 different windows and also 10 windows.

Comment 9

[duffman2332]

Possible related to Bug 1534327?

I was able to reproduce on Firefox Version 123.0.1 with Ubuntu 22.04 LTS and also discovered a specific behavior:

When 3 tabs are set to open on startup in the 'homepage and new windows' setting, the following inconsistency can be seen:

1.) Open new Firefox window with 3 tabs set to automatically load
2.) Drag the first two tabs into their own windows, making a total of 3 windows
3.) Right click Firefox on the dock and select Quit 3 windows
4.) Reopen Firefox
5.) The only open window will be the second tab that was dragged out from the original window, so only one of two of the dragged-out tabs remained.

If you repeat the same steps, but after making the 2 new windows, you do a simple search in only one of the windows so that the current page gets updated, and then close and reopen Firefox, only the window where the search occurred will still be open.
If you instead do the search in the original window, then all three windows will be open upon restoration instead of just the original window.