Open Bug 1875809 Opened 2 years ago Updated 2 years ago

Directly call SubstringKernel in self-hosted code

Categories

(Core :: JavaScript Engine: JIT, task, P3)

task

Tracking

()

People

(Reporter: anba, Unassigned)

References

(Blocks 1 open bug)

Details

We should try to remove the Substring wrapper function which just forwards to SubstringKernel and instead directly call SubstringKernel in self-hosted code. This requires at least two changes:

  1. CacheIR compiling for SubstringKernel needs to handle the case when int32 values are typed as doubles.
  2. Warp transpiling SubstringKernel needs to add the Math.max calls which were added bug 1874929. We then need to verify GVN can remove these additional Math.max when SubstringKernel is called from the self-hosted String.prototype.{sustring,substr,slice} functions.
See Also: → 1812655, 1374011
Blocks: sm-js-perf
Severity: -- → S3
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.