1875960 - mobile doesn't use most files installed in defaults/settings

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, defect)

Description

[Mike Hommey [:glandium]]

Per mobile/android/installer/package-manifest.in, the only files used from dist/bin/defaults/settings are:

defaults/settings/last_modified.json
defaults/settings/blocklists/gfx.json
defaults/settings/main/password-recipes.json
defaults/settings/security-state/onecrl.json

As such, all the other files that are in dist/bin/defaults/settings shouldn't be in dist/bin in the first place in mobile builds (apparently thunderbird installs them, but maybe that's a result of cargo culting rather than a deliberate choice).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:leplatrem, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Mathieu Leplatre [:leplatrem]]

Do you mean that moz.build should be adjusted to the list in package-manifest.in?

I don't know the subtleties of the packaging system, but with a little bit of hand hold, I would be happy to help clean this up and make docs clearer.

Comment 4

[Mike Hommey [:glandium]]

(In reply to Mathieu Leplatre [:leplatrem] from comment #3)

Do you mean that moz.build should be adjusted to the list in package-manifest.in?

Yes.

Comment 5

[Mark Banner (:standard8)]

I was in the area looking at something related so I fixed this whilst I was there. Should have a patch up later today.

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1875960 - Use the build system rather than package-manifest.in, to govern which remote settings dumps are packaged. r?leplatrem!,#build!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e228b638331
Use the build system rather than package-manifest.in, to govern which remote settings dumps are packaged. r=leplatrem,firefox-build-system-reviewers,geckoview-reviewers,glandium,m_kato

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3e228b638331