1876049 - [wpt-sync] Sync PR 44139 - [webdriver] Fix assertion for type hint when opening a new window on Android

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44139 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44139
Details from upstream follow.

Henrik Skupin <[e-mail]> wrote:

[webdriver] Fix assertion for type hint when opening a new window on Android

For the New Window command on Android the type hint when set to window should be handled as tab instead given that on Android each application has a single window only. As listed under point 5 in the WebDriver classic spec it is implementation defined:

In all other cases the details of how the browsing context is presented to the user are implementation defined.

Wdspec tests for Chrome on Android are passing even through the checks for the returned type hint is window.

Given the above explanation we should probably assert for tab instead. I assume returning window for Chrome on Android is a bug and needs to be fixed?

For Firefox we will enable the fallback to tab in https://bugzilla.mozilla.org/show_bug.cgi?id=1875085.

@sadym-chromium @nechaev-chromium could you please check / revivew? Thanks.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d57ec75d0a294034ef9fcb90632bfc2eecd1ff58

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
PASS: 6

Chrome

OK : 1
PASS: 6

Safari

OK : 1
PASS: 5
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webdriver/tests/classic/new_window/new_window.py [wpt.fyi]: OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)

Tests Disabled in Gecko Infrastructure

• /webdriver/tests/classic/new_window/new_window.py [wpt.fyi]: OK [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/011ed3291306
[wpt PR 44139] - [webdriver] Fix assertion for type hint when opening a new window on Android, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/011ed3291306