187605 - nsLocalFileCommon's InitWithFile should throw NS_ERROR_INVALID_ARG instead

Status: VERIFIED FIXED

(Core :: XPCOM, defect)

Description

[Sören 'Chucker' Kuklau (gone)]

The everything-except-mac method InitWithFile (
http://lxr.mozilla.org/mozilla/source/xpcom/io/nsLocalFileCommon.cpp#59 ) in
nsLocalFileCommon currently throws the rather meaningless NS_ERROR_FAILURE when
the path is empty, whereas the mac-specific InitWithNativePath (
http://lxr.mozilla.org/mozilla/source/xpcom/io/nsLocalFileMac.cpp#1107 ) throws
NS_ERROR_INVALID_ARG at the same check.

According to biesi, NS_ERROR_INVALID_ARG makes more sense. Severity "minor" as
this is a one-line-fix.

Comment 1

[Boris Zbarsky [:bzbarsky]]

post a patch?

Comment 2

[Sören 'Chucker' Kuklau (gone)]

Attachment: 1st patch

Comment 3

[Sören 'Chucker' Kuklau (gone)]

> post a patch?

Give me a break, I submitted it 11 minutes after filing the bug :-)

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 110603 [details] [diff] [review]
1st patch

r=dougt

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 110603 [details] [diff] [review]
1st patch

let me know if you need this checked in.

Comment 6

[Boris Zbarsky [:bzbarsky]]

fixed.

Comment 7

[Sören 'Chucker' Kuklau (gone)]

> let me know if you need this checked in.Should you refer to me: Yes, please.

Comment 8

[Sören 'Chucker' Kuklau (gone)]

v