1876146 - Remove the fail-if notation for `browser_acknowledgeFeedbackAndDismissal.js` that is passing a11y_checks

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Anna Yeddi [:ayeddi]]

The browser/components/urlbar/tests/browser/browser_acknowledgeFeedbackAndDismissal.js used to fail a11y_checks with the following failure and warning messages:

browser/components/urlbar/tests/browser/browser_acknowledgeFeedbackAndDismissal.js	Interactive elements must be labeled		menuitem	urlbarView-result-menuitem
browser/components/urlbar/tests/browser/browser_acknowledgeFeedbackAndDismissal.js	Unlabeled element removed before l10n finished		menuitem	urlbarView-result-menuitem -

But since the bug 1871491 and bug 1867170 fine-tuned the AccessibilityUtils to better check for an unlabeled Url Bar Option and to check parents of a context menu elements too, the test has been passing, so we could remove the fail-if notation from its test manifest.

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1876146 - Remove the fail-if notation for `browser_acknowledgeFeedbackAndDismissal.js` that is passing a11y_checks. r=Standard8!

The browser/components/urlbar/tests/browser/browser_acknowledgeFeedbackAndDismissal.js used to fail a11y_checks with the failed or incompleted label checks (when an unlabeled element removed before l10n finished). But since the bug 1871491 and bug 1867170 fine-tuned the AccessibilityUtils to better check for an unlabeled Url Bar Option and to check parents of a context menu elements too, the test has been passing, so we could remove the fail-if notation from its test manifest.

Depends on D197335

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc59c0f8cad6
Remove the fail-if notation for `browser_acknowledgeFeedbackAndDismissal.js` that is passing a11y_checks. r=Standard8

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/fc59c0f8cad6