1876333 - Randomize the Report Broken Site "select a reason" dropdown

Status: RESOLVED FIXED

(Web Compatibility :: Tooling & Investigations, task)

Description

[Thomas Wisniewski [:twisniewski]]

This is just to help us reason about the experimental results we're seeing from the feature.

Comment 1

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1876333 - randomize the order of the items in the Report Broken Site 'choose reason' dropdown; r?gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bca1a948f14
randomize the order of the items in the Report Broken Site 'choose reason' dropdown; r=Gijs

Comment 3

[Cristian Tuns]

Backed out for causing bc failures in browser_startup_mainthreadio.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_mainthreadio.js | unexpected stat on C:\Users\task_170620204956565\AppData\Local\Temp\tmp4j4k25vt.mozrunner\cert9.db before handling user events -

Comment 4

[Thomas Wisniewski [:twisniewski]]

It turns out that we can't use the crypto web API to shuffle our list of options during startup, as it causes main thread IO perf issues. So I'll copy array-shuffling code from https://searchfox.org/mozilla-central/source/browser/components/urlbar/QuickActionsLoaderDefault.sys.mjs#295 instead. I'm doing a try-run now to confirm this: https://treeherder.mozilla.org/jobs?repo=try&revision=b133d7906b6709a8e4493463a53ef25cc9e4e5be

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a507cc2cf84
randomize the order of the items in the Report Broken Site 'choose reason' dropdown; r=Gijs

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2a507cc2cf84

Comment 7

[Thomas Wisniewski [:twisniewski]]

Comment on attachment 9376377 [details]
Bug 1876333 - randomize the order of the items in the Report Broken Site 'choose reason' dropdown; r?gijs

Beta/Release Uplift Approval Request

• User impact if declined: Negligible. This is necessary for us to properly assess the impact of our Report Broken Site webcompat experiment.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky. This only affects users currently enrolled in a limited experiment, only affects that feature, and does so in a very limited way.
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9376377 [details]
Bug 1876333 - randomize the order of the items in the Report Broken Site 'choose reason' dropdown; r?gijs

Approved for 122.0.1

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/902aaea15298

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9376377 [details]
Bug 1876333 - randomize the order of the items in the Report Broken Site 'choose reason' dropdown; r?gijs

Approved for 123 beta 8, thanks.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/65d69c56b922

Comment 12

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/65d69c56b922