Closed
Bug 1876381
Opened 1 year ago
Closed 1 year ago
Rename `TestProvider._results` to `.results`
Categories
(Firefox :: Address Bar, task, P3)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
124 Branch
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: adw, Assigned: adw)
References
(Regressed 1 open bug)
Details
Attachments
(1 file)
This is spun out from https://phabricator.services.mozilla.com/D199176#inline-1105686. For simplicity we should make TestProvider._results a non-"private" property and rename it .results. There are a number of tests access it directly anyway.
There are a bunch of other "private" properties on TestProvider and we should probably just make them public too.
|
Assignee | |
Updated•1 year ago
|
Assignee: nobody → adw
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•1 year ago
|
||
In the end I wasn't able to remove underscores on a lot of these since the base
UrlbarProvider class defines getters and methods with the same names, but at
least results is no longer "private".
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/486dd659a14a
Remove underscores for some UrlbarTestUtils.TestProvider properties. r=mak
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox124:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•