1876811 - Remove some cached prefs from nsPresContext

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Daniel Holbert [:dholbert]]

Followup on https://phabricator.services.mozilla.com/D199690 review feedback: nsPresContext has several cached prefs, which were probably cached for performance reasons (so that we can check the value quickly when we need it). But nowadays we have StaticPrefs pref-getters which are fast, so there's probably no need for nsPresContext to do this caching.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1876811: Change about:config pref 'dom.send_after_paint_to_content' to a static pref instead of defining it in all.js. r?TYLin

While we're at it, remove the nsPresContext's caching machinery for this pref,
and just directly use the StaticPrefs getter at the one usage site.

This patch doesn't affect behavior.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1876811: Remove nsPresContext's cache for about:config pref bidi.direction. r?TYLin

Instead, just directly use the StaticPrefs getter for this pref at all the
usage-sites (including the callsite of GetCachedIntPref that queries for this
value via a no-longer-necessary enum value).

This patch doesn't change behavior.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: Bug 1876811: Remove nsPresContext's cache for about:config pref "layout.scrollbar.side". r?TYLin

Instead, just directly use the StaticPrefs getter for this pref at the one
usage-site, and remove the now-unnecessary GetCachedIntPref getter and
enum-parameter-type that was previously used to query the value.

This patch doesn't change behavior.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b7e8a3f4751
Change about:config pref 'dom.send_after_paint_to_content' to a static pref instead of defining it in all.js. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/2e6f427c053a
Remove nsPresContext's cache for about:config pref bidi.direction. r=TYLin,emilio
https://hg.mozilla.org/integration/autoland/rev/d7fa22972e13
Remove nsPresContext's cache for about:config pref "layout.scrollbar.side". r=TYLin

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (Bug 1876811) for causing failures in nsGfxScrollFrame.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d7fa22972e13f640cb97552bbb723ff1f514d3ea&selectedTaskRun=DgN_CbtiTJWpfh1O1KNXKg.0

Log: https://treeherder.mozilla.org/logviewer?job_id=444830135&repo=autoland&lineNumber=31096

Backout: https://hg.mozilla.org/integration/autoland/rev/f4cfc18a20610afd3a44dedcfe3c8f65ef977856

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e1c10a5832c
Change about:config pref 'dom.send_after_paint_to_content' to a static pref instead of defining it in all.js. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/126b8c56970e
Remove nsPresContext's cache for about:config pref bidi.direction. r=TYLin,emilio
https://hg.mozilla.org/integration/autoland/rev/1e79d9e65ec0
Remove nsPresContext's cache for about:config pref "layout.scrollbar.side". r=TYLin

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for causing bp-nu bustages in nsGfxScrollFrame.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/layout/generic/nsGfxScrollFrame.cpp:6029:27: error: no member named 'bidi_direction' in namespace 'mozilla::StaticPrefs'

Comment 8

[Daniel Holbert [:dholbert]]

D'oh, sorry about that. I probably need an include for StaticPrefs_bidi.h or something.

I'll take a look and reland on Monday.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ca084cba295
Change about:config pref 'dom.send_after_paint_to_content' to a static pref instead of defining it in all.js. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/967e096791ea
Remove nsPresContext's cache for about:config pref bidi.direction. r=TYLin,emilio
https://hg.mozilla.org/integration/autoland/rev/0f372a16b1e1
Remove nsPresContext's cache for about:config pref "layout.scrollbar.side". r=TYLin

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4ca084cba295
https://hg.mozilla.org/mozilla-central/rev/967e096791ea
https://hg.mozilla.org/mozilla-central/rev/0f372a16b1e1