1876818 - Footgun: deserialization arg type mismatch due to ClientWebGLContext caller vs HostWebGLContext callee

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, task, P1)

Description

[Kelsey Gilbert [:jgilbert]]

I ran into this when I tried adding a std::variant<size_t,...> arg in HostWebGLContext, but invoked ClientWebGLContext::Run with size_t, and the std::variant serialization code didn't even get compiled, because it would directly serialize a size_t, but deser would try to read it as a variant! Oops!

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1876818 - ClientWebGLContext::Run serialization now coerces to HostWebGLContext arg types.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b7eadc28250
ClientWebGLContext::Run serialization now coerces to HostWebGLContext arg types. r=gfx-reviewers,lsalzman

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing hazard-linux bustage in ClientWebGLContext.h.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | hazards | unrooted '__temp_1' of type 'std::optional<JS::AutoCheckCannotGC>' live across GC call at dom/canvas/ClientWebGLContext.h:2320

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5738e7d139a9
ClientWebGLContext::Run serialization now coerces to HostWebGLContext arg types. r=gfx-reviewers,lsalzman

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5738e7d139a9