1876834 - [wpt-sync] Sync PR 44234 - layout: Round getClientRect queries to pixels properly

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44234 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44234
Details from upstream follow.

Oriol Brufau <[e-mail]> wrote:

layout: Round getClientRect queries to pixels properly

Instead of just flooring all pixels in getClientRect queries, we should
round the rectangle.

<!-- Please describe your changes on the following line: -->

Reviewed in servo/servo#31187

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e32125acc78e8cda65ac0380190024106f9618f5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 15 subtests

Status Summary

Firefox

OK : 1
PASS: 12
FAIL: 3

Chrome

OK : 1
PASS: 12
FAIL: 3

Safari

OK : 1
PASS: 12
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/cssom-view/subpixel-sizes-and-offsets.tentative.html [wpt.fyi]
  • clientLeft and clientTop don't round 44.9: FAIL (Chrome: FAIL, Safari: FAIL)
  • clientLeft and clientTop don't round 44.5: FAIL (Chrome: FAIL, Safari: FAIL)
  • clientLeft and clientTop don't round 44.1: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44cb9efad6ff
[wpt PR 44234] - layout: Round `clientTop`, etc queries to pixels properly, a=testonly
https://hg.mozilla.org/integration/autoland/rev/84dff2eb8c54
[wpt PR 44234] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/44cb9efad6ff
https://hg.mozilla.org/mozilla-central/rev/84dff2eb8c54