18774 - [feature] Increase/Decrease font size need to be written

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect, P3)

Description

[Charles Manske]

The HTML font size is always confusing to non HTML geeks, so use simple
"Increase Font Size" and "Decrease Font Size" buttons.
This should increase/decrease all text in a selection by 1 HTML unit,
adjusting existing "FONT SIZE=" values. Underlying code (nsHTMLEditor methods)
also need to be implemented.

Comment 1

[Charles Manske]

UI (the toolbar buttons) is implemented. Core methods
nsHTMLEditor::IncreaseFontSize and DecreaseFontSize need to be written.

Comment 2

[Kathleen :Brade]

I see these new icons in the toolbar today but they don't seem to work.
This is a dogfood issue (need to be able to change the size of the text).
Change title to reflect latest comments by cmanske.

How do the new UI elements work if some of the selection is size 1 and some size
2?  Does it make them all size 2 or increment each part individually or make them
all size 3 or ???

Comment 3

[leger]

Putting on PDT- radar.  Not needed for dogfood.

Comment 4

[Charles Manske]

Moving to M13

Comment 5

[Kathleen :Brade]

*** Bug 21755 has been marked as a duplicate of this bug. ***

Comment 6

[rubydoo123]

setting to m16 and reassigning to jfrancis

Comment 7

[Joe Francis]

moving to m14.  who needs sleep...

Comment 8

[rubydoo123]

setting keyword

Comment 9

[leger]

Putting on PDT- radar for beta1.  Not critical to beta.

Comment 10

[Joe Francis]

fixed.  Sujay, it should be in todays build.  You dont need to wait a day.

Comment 11

[sujay]

it works, but we convert the indented text to blockquote style....

verified in 2/9 build.

Comment 12

[sujay]

I'm reopening this because it increase/decrease font size does not
work for partial text selection using 7/6 build.

1) enter some text
2) highlight half of the text
3) increase/decrease font size

nothing happens..

works if you select all of the text.

Comment 13

[Joe Francis]

fix in hand, very simple fix.

Comment 14

[Joe Francis]

fixed

Comment 15

[sujay]

verified in 7/25 build

Comment 16

[TucsonTester2]

Build 2001091303
Win95 OSR-2 
Bug status is listed as fix but after highlighting text in
composer documents and using the keyboard shortcuts cntrl+= and cntrl+-
I noted the font size is still not being altered at all 
21755 also documents this occuring when attempting to resize with the
tool bar and that is also not fixed. 
Reproducible: Everytime

Comment 17

[Charles Manske]

Isn't the "new" problem simply a dup of bug 99406?

Comment 18

[Kathleen :Brade]

no, it's yet a different problem.  I think it's either that the shortcut keys 
don't work on Windows or that someone else has defined a conflicting shortcut key 
so ours isn't getting triggered.  Regardless, please do NOT open up bugs that 
were fixed and verified more than 6 months ago.  I believe there *is* a bug filed 
on the issue raised above (look for "ctrl-+").

Comment 19

[Charles Manske]

Using Ctrl + and Ctrl - work just fine to increase/decrease font size of both 
selected text or at the caret (Windows2000, build from 9/20/01.
Please be sure there are not <font size=...> tags in the text you are testing.

Comment 20

[Kathleen :Brade]

Regardless of current behavior, please take it to another bug; this bug is 
ancient.

Fixed/Verified Bugs older than 6 months should be left as such.

Comment 21

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/d3ed7896c9d6
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18774: Move SelectionInteractor to new package
https://hg.mozilla.org/releases/mozilla-beta/rev/f94dfae96199
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/18774: Migrate mutli-selection to store
https://hg.mozilla.org/releases/mozilla-beta/rev/4ed5a951aed5
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/18774: Fix long parameter warnings in detekt