1877451 - "Rev ... seems to be marked as WIP" should not be a temporary error

Status: RESOLVED FIXED

(Conduit :: Lando, defect, P2)

Description

[Zeid [:zeid]]

STR:

• Try to land a revision with "WIP" in the commit message (title).

Expected behaviour:

• hgmo will reject the push, and Lando will mark the landing job as permanently failed.
• Lando will move along to the next landing job.

Actual behaviour:

• hgmo rejects the push, but Lando treats it as an HgmoInternalServerError, which gets marked as a temporary error.
• Lando continues to try to land this landing job over and over again.

Comment 1

[Zeid [:zeid]]

This is affecting other types of hgmo errors as well, for example, changes to "protected directories".

Comment 2

[BMO Github Automation]

Attachment: [mozilla-conduit/lando-api] hg: change push failure snippet to be more pushlog specific (Bug 1877451) (#376)