Open Bug 1877490 Opened 1 year ago Updated 1 year ago

Make it obvious that trying to land a WIP commit will fail

Categories

(Conduit :: Lando, defect)

defect

Tracking

(Not tracked)

People

(Reporter: nalexander, Unassigned)

References

Details

I had a poor experience trying to land a commit marked WIP. First, it's not clear how to remove the WIP bit from a commit. I thought that Request a Review would be enough but it appears not; after requesting review, https://lando.services.mozilla.com/D148559/ still failed to land with a message that says nothing about WIP:

Raw error output:
Unexpected error while pushing to ssh://hg.mozilla.org/integration/autoland.
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
remote: Connection to hg.mozilla.org closed by remote host.

Can we a) make the message more helpful; and b) make the Lando UI reject commits that are marked WIP? In this case I checked a Lando warning box saying, "yes, land this WIP commit" because I had requested review to clear the bit in the first place!

See Also: → 1877451, 1864825
You need to log in before you can comment on or make changes to this bug.