1877760 - [wpt-sync] Sync PR 44324 - Rework text-shadow painting for text decorations

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44324 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44324
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Rework text-shadow painting for text decorations

The current painting code-path for text-decorations with text-shadows is
complicated: line-throughs are painted using a draw-looper while the
rest of the decorations are painted for each shadow "layer" using a
DropShadowPaintFilter.

Unify these two by introducing a ScopedTextShadowPainter object that
constructs a filter - either a single DropShadowPaintFilter or a merge
filter combining one DropShadowPaintFilter for each layer. This makes
the two cases consistent, and for non-line-through decorations there's
no longer a need to run the paint code for each shadow "layer".

Bug: 1521809
Change-Id: I496d28672719e5efeee660dc780a96e433578456
Reviewed-on: https://chromium-review.googlesource.com/5250107
WPT-Export-Revision: a3005860bbbc655024614c5d616e05fceb5381b9

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b15a22993a85ca210865dff439f5215325aa7f1b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b76c352bc416
[wpt PR 44324] - Rework text-shadow painting for text decorations, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b76c352bc416