187796 - make unimplemented constructors in mozJSComponentLoader.h private

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[timeless]

bug 134728 shows that there is a non trivial constructor

    88                 JSCLAutoContext(); // not implemnted

I think that the comment should be removed.

Comment 1

[timeless]

Attachment: remove comment

Comment 2

[John Bandhauer]

Trivialand!

I don't see an implementation of a ctor taking no args for this class. A
declaration with no body (and containing that comment - misspelled or otherwise)
is my lontime pattern to indicate a class that should not be instantiated with a
default (no args) ctor. It may not be the *best* pattern. But it will cause a
failure to link if such a use of the class should appear.

Marking invalid.

Comment 3

[David Bradley]

Just an FYI.

1. Ideally it should be private, then it becomes a compile time issue not a link
time issue.
2. Since there is a non-trivial constructor, there's really no need to do this.

Comment 4

[timeless]

Attachment: make unimplemented constructors private

Comment 5

[Phil Schwartau]

Marking Verified -

Comment 6

[David Bradley]

reopening. I know this isn't a big issue, but it would be good to get things
cleaned up, and the change is trivial. Remove the unimplemented default
constructor and add a private/unimplemented copy constructor and assignment
operator.

Comment 7

[timeless]

Attachment: prevent copying and assignment. default constructor isn't allowed because there is a non default

Comment 8

[timeless]

Attachment: compiling version: prevent copying and assignment.

Comment 9

[David Bradley]

Comment on attachment 111414 [details] [diff] [review]
compiling version: prevent copying and assignment.

r=dbradley

Comment 10

[timeless]

http://hg.mozilla.org/mozilla-central/rev/f0ad730b1951