1877997 - Add damp to cover some actions on large minified files. when wrapping lines is turned on.

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Hubert Boma Manilla (:bomsy)]

The Wrap lines setting is off by default. When they are turned on very large minified file (which is usually a single long line), will cause the line to wrap vertically taking up space in the editor and overflowing vertically.

There seems some visible performance issues interacting with files like these, so I've seen

• Loading these take some time
• Setting a breakpoint seems to take time to show
• Scrolling with breakpoints set on one line seems janky.

Though this is not a default setting, it can impact on users, which who want to use the feature.

Lets add damp tests to track some of these, and see possible fixes.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1877997 - [devtools] DAMP some tests for large file with editor content wrapping turned on r=#devtools-reviewers

Adding a new test file for special or edge cases which might not be on the main workflow
(e.g cases which require toggle of a pref which is off by default )

This patch specifically adds tests for large files with the devtools.debugger.ui.editor-wrapping enabled.

• Test how long it takes a large wrapped file to load and get displayed.
• Test how long it takes to add a breakpoint to the file
• Test how long it takes to scroll the file

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:bomsy, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Alex Finder]

Hi Hubert, is the patch still being worked on ? I see it's accepted on Phabricator, but has not yet landed.

Comment 4

[Hubert Boma Manilla (:bomsy)]

Hi Alex,
Apologies for the slow response. The patch is still been worked on, there are some discrepancies with the results for DAMP tests that are produced, which we are currently investigating .. I'll switch the patch to "plan changes"

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57c89b4a7631
[devtools] DAMP some tests for large file with editor content wrapping turned on r=devtools-reviewers,perftest-reviewers,afinder,ochameau,nchevobbe

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/57c89b4a7631